Remove unwrap()'s about miniserve HOT 7 CLOSED

Yeah, that'd be a good effort.

from miniserve.

Just one quick question, do you mind having an enum with all miniserve's error kind, or do you want them to be split like right now, aka CompressionErrorKind, UploadErrorKind, etc ? In the latter case, I think I need to implement Fail, Display, etc, for all those enums, so some copy/paste. Having a single enum allows to implement it once for good, but that's 1 quite big enum. Your call :)

PS: there might be a third solution, that would allow to have separate enums, but only 1 implementation, but sadly I can't figure out how...

from miniserve.

Ok so honestly I'm thinking hard about both ways and I think I'm entirely balanced concerning my opinion on the matter. For one, it seems nice to have separate errors for separate parts of the application but then again we might also run into scenarios where an error fits into neither category and that'd be awkward.

Cutting down on boilerplate is always nice, of course.

I'll let you make the call on this.

from miniserve.

The argument about an error fitting into no/several categories is very true, didn't think about that. This will probably be the case with IoError, which can happen during compressing, and during uploading.

from miniserve.

from miniserve.

Glad to hear you like it!

from miniserve.

Leaving this open until the very last unwrap() is gone :P

from miniserve.