Cannot find module './preprocess.js' about svelte-jester HOT 13 CLOSED

It shows up for me in dist/ when I build locally. @mihar-22 maybe you accidentally published an old version or something?

@colehpage note that it's only the CJS version that needs that file. If you switch to ESM you'll avoid that issue and get better performance

Yeah, it is missing in the published version. @mihar-22

Weird though, because release should call build. Does it need to be added to the files property here https://github.com/mihar-22/svelte-jester/blob/master/package.json#L38?

from svelte-jester.

Rollup does not transform preprocess, so that is also a reason it is missing.

It is copied there during npm run build (https://github.com/mihar-22/svelte-jester/blob/master/package.json#L43)

from svelte-jester.

There wasn't a build step before and it wasn't added to the release command so I didn't realize it was required. Fixed in 2.1.4!

from svelte-jester.

There wasn't a build step before and it wasn't added to the release command so I didn't realize it was required. Fixed in 2.1.4!

Thanks mate! Really appreciate the work on all this and especially the quick responses, it's a huge help. EDIT: I'm not sure if it's fixed in 2.1.4 I don't see preprocess.js being added in dist/ during the build yet, but I may just be tired so I'll take a look in the morning

from svelte-jester.

yep also can confirm preprocess is still missing in 2.1.4. @mihar-22

from svelte-jester.

It shows up for me in dist/ when I build locally. @mihar-22 maybe you accidentally published an old version or something?

@colehpage note that it's only the CJS version that needs that file. If you switch to ESM you'll avoid that issue and get better performance

from svelte-jester.

Ahh that makes sense - thanks for the tip @benmccann ill give that a go then, was meaning to go the ESM route anyway, should have tried that first.

from svelte-jester.

Rollup does not transform preprocess, so that is also a reason it is missing.

from svelte-jester.

Thank you for the quick release, but I think @colehpage is right: preprocess.js seems to be still missing in 2.1.4.

from svelte-jester.

There wasn't a build step before and it wasn't added to the release command so I didn't realize it was required. Fixed in 2.1.4!

Thanks mate! Really appreciate the work on all this and especially the quick responses, it's a huge help. EDIT: I'm not sure if it's fixed in 2.1.4 I don't see preprocess.js being added in dist/ during the build yet, but I may just be tired so I'll take a look in the morning

Here https://github.com/mihar-22/svelte-jester/blob/master/package.json#L43

from svelte-jester.

According to https://docs.npmjs.com/cli/v7/commands/npm-publish#files-included-in-package, we need to add it to the files property.

from svelte-jester.

Just reproduced in CI.

Downgrading to 1.7 works fine.

from svelte-jester.

This was just fixed in #84 and should work when version 2.1.5 is released

from svelte-jester.