Giter Club home page Giter Club logo

Comments (11)

leng-yue avatar leng-yue commented on July 28, 2024 2

根据 content vec 原作者的信息, final_proj 是一个错误的用法, 但是不幸的是我们现在所有的模型都在用 (

from so-vits-svc.

hongwen-sun avatar hongwen-sun commented on July 28, 2024

还有个疑问:

logits = model.extract_features(**inputs)
feats = model.final_proj(logits[0])

这部分代码提取的第9层的信息,又经过了final_proj的结构,这样是bug还是有意为之?我的理解是最后一层经过它才是合理的

from so-vits-svc.

leng-yue avatar leng-yue commented on July 28, 2024

我个人倾向于第 9 层是故意的, 但是 final proj 是不小心的...
有不少论文讨论了不同层的 feature 是有区别的, 第 9 层可能是从这些论文来的.
原理上不应该经过 final proj, 但是可能经过了也不影响, 最多丢点信息. 具体得问开发第一版本的佬了...

from so-vits-svc.

w-okada avatar w-okada commented on July 28, 2024

So, does officail svc-develop-team have any plan to fix this usage of content vec?

from so-vits-svc.

Likkkez avatar Likkkez commented on July 28, 2024

Fix when? pls

from so-vits-svc.

MuruganR96 avatar MuruganR96 commented on July 28, 2024

Fix when? pls

https://huggingface.co/lengyue233/content-vec-best

from so-vits-svc.

Likkkez avatar Likkkez commented on July 28, 2024

Fix when? pls

https://huggingface.co/lengyue233/content-vec-best

Sorry I'm a bit confused. What do i need to do with that to apply the fix to so-vits-svc?

from so-vits-svc.

MuruganR96 avatar MuruganR96 commented on July 28, 2024

This is fixed in https://github.com/34j/so-vits-svc-fork.

Check out this issue: voicepaw/so-vits-svc-fork#213
Check out this PR: voicepaw/so-vits-svc-fork#197

in utils.py. get_hubert_content https://github.com/svc-develop-team/so-vits-svc/blob/4.0/utils.py#L225

    with torch.no_grad(), timer() as t:
        params = {"output_layer": 9} if legacy_final_proj else {}
        c: torch.Tensor = cmodel.extract_features(audio, **params)[0]
        if legacy_final_proj:
            warnings.warn("legacy_final_proj is deprecated")
            assert hasattr(cmodel, "final_proj")
            assert isinstance(cmodel.final_proj, torch.nn.Module)
            c = cmodel.final_proj(c)
        c = c.transpose(1, 2)

I haven't tried yet.

from so-vits-svc.

Likkkez avatar Likkkez commented on July 28, 2024

This is fixed in https://github.com/34j/so-vits-svc-fork.

Check out this issue: 34j/so-vits-svc-fork#213 Check out this PR: 34j/so-vits-svc-fork#197

in utils.py. get_hubert_content https://github.com/svc-develop-team/so-vits-svc/blob/4.0/utils.py#L225

    with torch.no_grad(), timer() as t:
        params = {"output_layer": 9} if legacy_final_proj else {}
        c: torch.Tensor = cmodel.extract_features(audio, **params)[0]
        if legacy_final_proj:
            warnings.warn("legacy_final_proj is deprecated")
            assert hasattr(cmodel, "final_proj")
            assert isinstance(cmodel.final_proj, torch.nn.Module)
            c = cmodel.final_proj(c)
        c = c.transpose(1, 2)

I haven't tried yet.

Alright, I'll try. thanks!

from so-vits-svc.

MuruganR96 avatar MuruganR96 commented on July 28, 2024

@Likkkez refer this options -> https://github.com/yxlllc/DDSP-SVC/blob/master/ddsp/vocoder.py#L114

from so-vits-svc.

Likkkez avatar Likkkez commented on July 28, 2024

@Likkkez refer this options -> https://github.com/yxlllc/DDSP-SVC/blob/master/ddsp/vocoder.py#L114

A ye thanks! I think now theres also a branch here that does the same thing right? The '4.0-Vec768-Layer12'.

from so-vits-svc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.