Giter Club home page Giter Club logo

Comments (5)

aspiers avatar aspiers commented on July 18, 2024

#760 implements a lot of this, but we still need to change the triggers so that they set the new $clouddescription.

from automation.

jdsn avatar jdsn commented on July 18, 2024

@aspiers with #1404 now merged, is there anything left from this issue to be implemented? If not lets close this issue.

from automation.

aspiers avatar aspiers commented on July 18, 2024

@jdsn It's looking almost awesome, except that:

  • There is a quoting bug which I've fixed in #1410.
  • For some reason /etc/motd is written late, in the onadmin_add_cloud_repo step. This makes no sense to me. It should be in its own onadmin_write_motd function, which should be called from the setupadmin step. Please can you clean that up?

from automation.

jdsn avatar jdsn commented on July 18, 2024

@aspiers
Yes, it is written late because it depends on onadmin_add_cloud_repo to write the file /etc/cloudversion. By moving it earlier, we either lose the info from that file in motd or we have to add it to motd later.

from automation.

aspiers avatar aspiers commented on July 18, 2024

or we have to add it to motd later.

@jdsn That sounds more sensible to me. There's no reason why we have to create /etc/motd in a single go, is there?

from automation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.