Giter Club home page Giter Club logo

Comments (10)

rushmorem avatar rushmorem commented on June 8, 2024

When adding such a feature, it's also best practice to give users a way to disable it.

a date-based version check for upgrades

I'm not sure what your plans here are. Comparing the current version to the one from https://download.surrealdb.com/latest.txt should be enough, unless I'm missing something.

If its just URL then its prone to slow down start time

Not if you do the check in the background, which we should anyway.

from surrealdb.

phughk avatar phughk commented on June 8, 2024

Not if you do the check in the background, which we should anyway.
This is during startup. We don't want async messages in output. I don't mind how its implemented. I would just think synchronous would have been simple.

The latest.txt works for web requests. We also want to notify users who are offline and air-gapped.

from surrealdb.

rushmorem avatar rushmorem commented on June 8, 2024

So you plan to do that by comparing the time that has elapsed since their release against our normal release cadence?

from surrealdb.

rushmorem avatar rushmorem commented on June 8, 2024

This is during startup. We don't want async messages in output.

Maybe for surreal sql but surreal start may run for a long time. I think periodic checks there are a good idea.

from surrealdb.

phughk avatar phughk commented on June 8, 2024

So you plan to do that by comparing the time that has elapsed since their release against our normal release cadence?

Yes exactly, but will give it a multiplier. For example "3 releases" should usually mean "yeah, there has been a release - we will not have missed 3 releases". So if you are offline and 3 months out of date, then we show the message.

from surrealdb.

rushmorem avatar rushmorem commented on June 8, 2024

Good idea 👍 In that case, it's unfortunate that we no longer include build metadata in tagged releases. That would have made this easier to implement. Without it, you will have to derive the release date first. On the flip side, not relying on such build metadata is more robust because on custom built binaries that metadata may be disabled too.

from surrealdb.

phughk avatar phughk commented on June 8, 2024

Will do a follow up PR to check binary date 😂 sys.args[0].create_time

from surrealdb.

rushmorem avatar rushmorem commented on June 8, 2024

Doesn't that just give you the date the binary was built @phughk?

from surrealdb.

phughk avatar phughk commented on June 8, 2024

Downloaded/modified, yes. Thats good enough until we have something better like metadata. People won't be modifying the binary if they are airgapped if not for upgrading I think

from surrealdb.

naisofly avatar naisofly commented on June 8, 2024

Merged in #3599!

from surrealdb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.