Bug: Matcher in request body crashes at `PactSwift.PactBuilder.process(element)` about pactswift HOT 3 CLOSED

This is doing my head in. The request body goes through the same processing as response body, yet when setting matchers in a response body, everything is all good and dandy. It's not when setting matchers in request body. Odd.

from pactswift.

Narrowed it down to body only containing one dict element or more elements of only one type of matcher.

The following is OK ✅:

[
  "name": Matcher.SomethingLike("Foo"),
  "age": Matcher.IntegerLike(42) 
]

The following is NOT OK ❌:

[
  "name": Matcher.SomethingLike("Foo"),
  "age": Matcher.SomethingLike(42) 
]

// or just
[
  "name": Matcher.SomethingLike("Foo")
]

A test case for these was not written at MockServiceTests in PactSwift and PactBuilder is failing to process it properly. Oddly enough, PactBuilderTests do cover testing single Matchers and the tests pass.

from pactswift.

It appears Swift doesn't consider any of PactSwift's matchers that conform to MatcherRuleExpressible as a type of MatcherRuleExpressible if there's only one in the dictionary for body in either Request or Response. Same if Request or Response contain multiple matchers (or example generators) of the same type.

This only happens if Response or Request is set post Interaction init (eg: Interaction(...).withRequest(_:)) If Response and Request with same body as described above are passed into the Interaction initializer (eg: Interaction(_:response:request:)) then matchers that conform to MatcherRuleExpressible are considered of type MatcherRuleExpressible and all is hunky dory. 🤦‍♂️

Fixed with 7c7c96c

from pactswift.