Giter Club home page Giter Club logo

Comments (15)

sureskumar avatar sureskumar commented on July 4, 2024 6

I will look into this today or tomorrow. Sorry for the delay guys!

from sketch-isometric.

bukinoshita avatar bukinoshita commented on July 4, 2024 1

tried latest version and it's working, I'm going to close this. Thanks

from sketch-isometric.

frankieGP avatar frankieGP commented on July 4, 2024

2nd that. Same issue.

from sketch-isometric.

dH3s1 avatar dH3s1 commented on July 4, 2024

Yes this definitely isn't generating anything in sketch v50. Hopefully this can be resolved soon.
Thanks.

from sketch-isometric.

sureskumar avatar sureskumar commented on July 4, 2024

@Gokul0 Looks like this part of the code is not working in Sketch v50.

var path = NSBezierPath.bezierPath(); path.moveToPoint(NSMakePoint(x1, y1)); path.lineToPoint(NSMakePoint(x4, y4)); path.closePath(); var shape = MSShapeGroup.shapeWithBezierPath(path); var border = shape.style().addStylePartOfType(0);

If you have time, can you please look into this? Cheers!

from sketch-isometric.

gokulanv avatar gokulanv commented on July 4, 2024

Ok sures, I ll look into it this week.

from sketch-isometric.

sureskumar avatar sureskumar commented on July 4, 2024

@Gokul0 The error I am getting is
-[NSBezierPath transformedPathUsingAffineTransform:]: unrecognized selector sent to instance 0x600000321a40

Any clue how to fix this?

from sketch-isometric.

gokulanv avatar gokulanv commented on July 4, 2024

From what I just saw, I think it pops up because we call a method that does not exist on the object. Will have to look into it. We may need to check if

bezierPath()

Function exists on the object in the first place

from sketch-isometric.

sureskumar avatar sureskumar commented on July 4, 2024

Thanks Gokul. The bug is now fixed in the latest version. Sorry for the inconvenience guys!

from sketch-isometric.

gokulanv avatar gokulanv commented on July 4, 2024

@sureskumar What was the issue?

from sketch-isometric.

sureskumar avatar sureskumar commented on July 4, 2024

Replacing this
var shape = MSShapeGroup.shapeWithBezierPath(path);
with this

var newBezier = MSPath.pathWithBezierPath(path);
var shape = MSShapeGroup.shapeWithBezierPath(newBezier);

solved it :)

from sketch-isometric.

gokulanv avatar gokulanv commented on July 4, 2024

I saw that in the commit. But why did we have to make this change? The old method invocation of

bezierPath ()

on the

NSBezierPath

object was removed or deprecated?

from sketch-isometric.

sureskumar avatar sureskumar commented on July 4, 2024

To be honest, I dont understand code in that level of depth :) I saw another plugin working in sketch 50 using this and I tried it :)

from sketch-isometric.

gokulanv avatar gokulanv commented on July 4, 2024

No probs, why is this now reopened?

from sketch-isometric.

leonardofed avatar leonardofed commented on July 4, 2024

Can't make this work with Sketch 49. Any updates?

from sketch-isometric.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.