DrawWings Behaviour Change about zircon HOT 5 CLOSED

I made the change, i think it's a better change for customisation.

Maybe some better naming convention for the enum values could be suggested.

from zircon.

In hindsight, the only thing I don't like about this approach is that Exterior Effect is visible for all items even though it's only usable by Wings, Armour and possibly Emblem in the future.

It's a small burden to live with, it would be better if we could filter the enum values to just 'None' for other item types if that's a possibility but I couldn't see where this would be possible yet.

Do you know if there it is possible to filter the results of this drop down based on the ItemType column? I would want this behaviour for weapons later if possible aswell.

from zircon.

Since in official there is no separate wings slot, it was my intention to eventually remove the "Wings" item type altogether and have the shape as an attribute you can assign to an armour.

It seems like you've done that job - and that the "shape" for the wings item type doesn't do anything now?

from zircon.

Technically yes shape is redundant for the wing slot now and armour effect is identical / shared with wing effect... but it has not completely been removed, like I think you mean. It is still in use on the client side to get the double wing effect as shown in the image.

09a48d1#diff-77e10abd04ca4a78bc27cf7c12c0429548381255375523586d3e2dbadbed2afeR1250-R1254

if (CEnvir.LibraryList.TryGetValue(LibraryFile.EquipEffect_Part, out MirLibrary library))
{
      DrawExteriorEffect(library, ArmourEffect);
      DrawExteriorEffect(library, WingsEffect);
}

from zircon.

I see. Yes ideally I want to remove "WingsShape" so the wing item type can be removed completely.

This would limit the ExteriorEffect to just armour so you can only have 1 effect - but personally i think thats less confusing (and easier on the eyes) anyway.

from zircon.