Comments (5)
I made the change, i think it's a better change for customisation.
Maybe some better naming convention for the enum values could be suggested.
from zircon.
In hindsight, the only thing I don't like about this approach is that Exterior Effect is visible for all items even though it's only usable by Wings, Armour and possibly Emblem in the future.
It's a small burden to live with, it would be better if we could filter the enum values to just 'None' for other item types if that's a possibility but I couldn't see where this would be possible yet.
Do you know if there it is possible to filter the results of this drop down based on the ItemType column? I would want this behaviour for weapons later if possible aswell.
from zircon.
Since in official there is no separate wings slot, it was my intention to eventually remove the "Wings" item type altogether and have the shape as an attribute you can assign to an armour.
It seems like you've done that job - and that the "shape" for the wings item type doesn't do anything now?
from zircon.
Technically yes shape is redundant for the wing slot now and armour effect is identical / shared with wing effect... but it has not completely been removed, like I think you mean. It is still in use on the client side to get the double wing effect as shown in the image.
09a48d1#diff-77e10abd04ca4a78bc27cf7c12c0429548381255375523586d3e2dbadbed2afeR1250-R1254
if (CEnvir.LibraryList.TryGetValue(LibraryFile.EquipEffect_Part, out MirLibrary library))
{
DrawExteriorEffect(library, ArmourEffect);
DrawExteriorEffect(library, WingsEffect);
}
from zircon.
I see. Yes ideally I want to remove "WingsShape" so the wing item type can be removed completely.
This would limit the ExteriorEffect to just armour so you can only have 1 effect - but personally i think thats less confusing (and easier on the eyes) anyway.
from zircon.
Related Issues (20)
- spells not locking on HOT 1
- accessory upgrade HOT 3
- Sin blooms does normal damage HOT 1
- DanceOfSwallow crashes all client connections when in visible range HOT 1
- Parasite Explosion Crashes Server if used on a player HOT 3
- Can Not Kick Guild Members From Guild
- Companion window cannot fit all item types in view
- cant choose a quest reaward in the Choice section
- Quest QoL Updates
- Menue Button dont work (click+N hotkey) HOT 2
- Confirmation for Sorting Button
- Wizard Skill Burning dont level
- Plz do update on gm commands and fix HOT 3
- Item link from equip Crash server
- PoisonDust technique issues
- Guild bonus removed while in grp with member of another guild HOT 2
- Some skill elements attack color settings without effect HOT 2
- linking items to chat in character menu HOT 2
- companion issue HOT 3
- Catapult and Ballista
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zircon.