No ethernet with Mecool M8S PRO+ (Using P212 dts) about meta-meson HOT 11 CLOSED

Hi,

It looks like the Ethernet phy driver hasn’t probed, can you run a lsmod and share a full boot log (dmesg) ?

from meta-meson.

lsmod:

dmesg:

[ 0.000000] Booting Linux on physical CPU 0x0000000000 [0x410fd034]
[ 0.000000] Linux version 4.17.1 (oe-user@oe-host) (gcc version 7.3.0 (GCC)) #1 SMP PREEMPT Fri Jul 27 13:57:22 UTC 2018
[ 0.000000] Machine model: Amlogic Meson GXL (S905X) P212 Development Board
[ 0.000000] Reserved memory: created CMA memory pool at 0x0000000072000000, size 188 MiB
[ 0.000000] OF: reserved mem: initialized node linux,cma, compatible id shared-dma-pool
[ 0.000000] On node 0 totalpages: 518912
[ 0.000000] DMA32 zone: 8128 pages used for memmap
[ 0.000000] DMA32 zone: 0 pages reserved
[ 0.000000] DMA32 zone: 518912 pages, LIFO batch:31
[ 0.000000] psci: probing for conduit method from DT.
[ 0.000000] psci: PSCIv0.2 detected in firmware.
[ 0.000000] psci: Using standard PSCI v0.2 function IDs
[ 0.000000] psci: Trusted OS migration not required
[ 0.000000] percpu: Embedded 23 pages/cpu @ (ptrval) s54552 r8192 d31464 u94208
[ 0.000000] pcpu-alloc: s54552 r8192 d31464 u94208 alloc=23*4096
[ 0.000000] pcpu-alloc: [0] 0 [0] 1 [0] 2 [0] 3
[ 0.000000] Detected VIPT I-cache on CPU0
[ 0.000000] CPU features: detected: Kernel page table isolation (KPTI)
[ 0.000000] CPU features: enabling workaround for ARM erratum 845719
[ 0.000000] Built 1 zonelists, mobility grouping on. Total pages: 510784
[ 0.000000] Kernel command line: root=/dev/mmcblk0p1 rootwait rw console=ttyAML0
[ 0.000000] Dentry cache hash table entries: 262144 (order: 9, 2097152 bytes)
[ 0.000000] Inode-cache hash table entries: 131072 (order: 8, 1048576 bytes)
[ 0.000000] Memory: 1835076K/2075648K available (7486K kernel code, 584K rwdata, 2716K rodata, 448K init, 343K bss, 48060K reserved, 192512K cma-reserved)
[ 0.000000] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=4, Nodes=1
[ 0.000000] Preemptible hierarchical RCU implementation.
[ 0.000000] RCU restricting CPUs from NR_CPUS=64 to nr_cpu_ids=4.
[ 0.000000] Tasks RCU enabled.
[ 0.000000] RCU: Adjusting geometry for rcu_fanout_leaf=16, nr_cpu_ids=4
[ 0.000000] NR_IRQS: 64, nr_irqs: 64, preallocated irqs: 0
[ 0.000000] GIC: Using split EOI/Deactivate mode
[ 0.000000] irq_meson_gpio: 110 to 8 gpio interrupt mux initialized
[ 0.000000] arch_timer: cp15 timer(s) running at 24.00MHz (phys).
[ 0.000000] clocksource: arch_sys_counter: mask: 0xffffffffffffff max_cycles: 0x588fe9dc0, max_idle_ns: 440795202592 ns
[ 0.000003] sched_clock: 56 bits at 24MHz, resolution 41ns, wraps every 4398046511097ns
[ 0.000285] Console: colour dummy device 80x25
[ 0.000304] Calibrating delay loop (skipped), value calculated using timer frequency.. 48.00 BogoMIPS (lpj=96000)
[ 0.000314] pid_max: default: 32768 minimum: 301
[ 0.000381] Security Framework initialized
[ 0.000418] Mount-cache hash table entries: 4096 (order: 3, 32768 bytes)
[ 0.000431] Mountpoint-cache hash table entries: 4096 (order: 3, 32768 bytes)
[ 0.020007] ASID allocator initialised with 32768 entries
[ 0.023999] Hierarchical SRCU implementation.
[ 0.032019] smp: Bringing up secondary CPUs ...
[ 0.052183] Detected VIPT I-cache on CPU1
[ 0.052228] CPU1: Booted secondary processor 0x0000000001 [0x410fd034]
[ 0.072209] Detected VIPT I-cache on CPU2
[ 0.072242] CPU2: Booted secondary processor 0x0000000002 [0x410fd034]
[ 0.092242] Detected VIPT I-cache on CPU3
[ 0.092274] CPU3: Booted secondary processor 0x0000000003 [0x410fd034]
[ 0.092335] smp: Brought up 1 node, 4 CPUs
[ 0.092354] SMP: Total of 4 processors activated.
[ 0.092360] CPU features: detected: 32-bit EL0 Support
[ 0.095128] CPU: All CPU(s) started at EL2
[ 0.095141] alternatives: patching kernel code
[ 0.095683] devtmpfs: initialized
[ 0.098695] random: get_random_u32 called from bucket_table_alloc+0x80/0x1b8 with crng_init=0
[ 0.099173] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645041785100000 ns
[ 0.099190] futex hash table entries: 1024 (order: 5, 131072 bytes)
[ 0.103535] pinctrl core: initialized pinctrl subsystem
[ 0.104114] NET: Registered protocol family 16
[ 0.104381] audit: initializing netlink subsys (disabled)
[ 0.104496] audit: type=2000 audit(0.104:1): state=initialized audit_enabled=0 res=1
[ 0.104815] cpuidle: using governor menu
[ 0.104913] vdso: 2 pages (1 code @ (ptrval), 1 data @ (ptrval))
[ 0.104924] hw-breakpoint: found 6 breakpoint and 4 watchpoint registers.
[ 0.108780] DMA: preallocated 256 KiB pool for atomic allocations
[ 0.108875] Serial: AMBA PL011 UART driver
[ 0.117375] HugeTLB registered 2.00 MiB page size, pre-allocated 0 pages
[ 0.117654] cryptd: max_cpu_qlen set to 1000
[ 0.119026] SCSI subsystem initialized
[ 0.119154] usbcore: registered new interface driver usbfs
[ 0.119183] usbcore: registered new interface driver hub
[ 0.119272] usbcore: registered new device driver usb
[ 0.119425] pps_core: LinuxPPS API ver. 1 registered
[ 0.119431] pps_core: Software ver. 5.3.6 - Copyright 2005-2007 Rodolfo Giometti [email protected]
[ 0.119443] PTP clock support registered
[ 0.119579] Advanced Linux Sound Architecture Driver Initialized.
[ 0.120082] clocksource: Switched to clocksource arch_sys_counter
[ 0.120214] VFS: Disk quotas dquot_6.6.0
[ 0.120361] VFS: Dquot-cache hash table entries: 512 (order 0, 4096 bytes)
[ 0.124503] NET: Registered protocol family 2
[ 0.124853] tcp_listen_portaddr_hash hash table entries: 1024 (order: 2, 16384 bytes)
[ 0.124881] TCP established hash table entries: 16384 (order: 5, 131072 bytes)
[ 0.124987] TCP bind hash table entries: 16384 (order: 6, 262144 bytes)
[ 0.125181] TCP: Hash tables configured (established 16384 bind 16384)
[ 0.125276] UDP hash table entries: 1024 (order: 3, 32768 bytes)
[ 0.125318] UDP-Lite hash table entries: 1024 (order: 3, 32768 bytes)
[ 0.125449] NET: Registered protocol family 1
[ 0.125788] RPC: Registered named UNIX socket transport module.
[ 0.125796] RPC: Registered udp transport module.
[ 0.125800] RPC: Registered tcp transport module.
[ 0.125804] RPC: Registered tcp NFSv4.1 backchannel transport module.
[ 0.126381] hw perfevents: enabled with armv8_cortex_a53 PMU driver, 7 counters available
[ 0.129687] Initialise system trusted keyrings
[ 0.129831] workingset: timestamp_bits=46 max_order=19 bucket_order=0
[ 0.134334] squashfs: version 4.0 (2009/01/31) Phillip Lougher
[ 0.134828] NFS: Registering the id_resolver key type
[ 0.134851] Key type id_resolver registered
[ 0.134856] Key type id_legacy registered
[ 0.134866] nfs4filelayout_init: NFSv4 File Layout Driver Registering...
[ 0.135007] 9p: Installing v9fs 9p2000 file system support
[ 0.137067] Key type asymmetric registered
[ 0.137079] Asymmetric key parser 'x509' registered
[ 0.137239] Block layer SCSI generic (bsg) driver version 0.4 loaded (major 246)
[ 0.137334] io scheduler noop registered
[ 0.137340] io scheduler deadline registered
[ 0.137496] io scheduler cfq registered (default)
[ 0.137502] io scheduler mq-deadline registered
[ 0.137507] io scheduler kyber registered
[ 0.137583] io scheduler bfq registered
[ 0.140313] gxbb-clkc c883c000.clock-controller: failed to get HHI regmap - Trying obsolete regs
[ 0.145586] soc soc0: Amlogic Meson GXL (S905X) Revision 21:b (82:2) Detected
[ 0.147953] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
[ 0.149153] c11084c0.serial: ttyAML1 at MMIO 0xc11084c0 (irq = 10, base_baud = 1500000) is a meson_uart
[ 0.149436] c81004c0.serial: ttyAML0 at MMIO 0xc81004c0 (irq = 13, base_baud = 1500000) is a meson_uart
[ 0.794124] console [ttyAML0] enabled
[ 0.802467] loop: module loaded
[ 0.803149] libphy: Fixed MDIO Bus: probed
[ 0.805098] tun: Universal TUN/TAP device driver, 1.6
[ 0.810342] meson8b-dwmac c9410000.ethernet: PTP uses main clock
[ 0.815845] meson8b-dwmac c9410000.ethernet: no reset control found
[ 0.822305] stmmac - user ID: 0x11, Synopsys ID: 0x37
[ 0.827055] meson8b-dwmac c9410000.ethernet: Ring mode enabled
[ 0.832833] meson8b-dwmac c9410000.ethernet: DMA HW capability register supported
[ 0.840282] meson8b-dwmac c9410000.ethernet: Normal descriptors
[ 0.846110] meson8b-dwmac c9410000.ethernet: RX Checksum Offload Engine supported
[ 0.853527] meson8b-dwmac c9410000.ethernet: COE Type 2
[ 0.858701] meson8b-dwmac c9410000.ethernet: TX Checksum insertion supported
[ 0.865687] meson8b-dwmac c9410000.ethernet: Wake-Up On Lan supported
[ 0.872107] meson8b-dwmac c9410000.ethernet: Enable RX Mitigation via HW Watchdog Timer
[ 0.880105] libphy: stmmac: probed
[ 0.885531] ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver
[ 0.889872] ehci-platform: EHCI generic platform driver
[ 0.895114] ohci_hcd: USB 1.1 'Open' Host Controller (OHCI) Driver
[ 0.901152] ohci-platform: OHCI generic platform driver
[ 0.906728] usbcore: registered new interface driver usb-storage
[ 0.913254] mousedev: PS/2 mouse device common for all mice
[ 0.918036] i2c /dev entries driver
[ 0.922075] sdhci: Secure Digital Host Controller Interface driver
[ 0.927365] sdhci: Copyright(c) Pierre Ossman
[ 0.931688] Synopsys Designware Multimedia Card Interface Driver
[ 0.938657] meson-gx-mmc d0072000.mmc: Got CD GPIO
[ 0.968888] meson-gx-mmc d0074000.mmc: allocated mmc-pwrseq
[ 0.995527] sdhci-pltfm: SDHCI platform and OF driver helper
[ 0.995923] ledtrig-cpu: registered to indicate activity on CPUs
[ 1.001899] meson-sm: secure-monitor enabled
[ 1.006151] usbcore: registered new interface driver usbhid
[ 1.007957] mmc0: new high speed SDHC card at address 59b4
[ 1.011339] usbhid: USB HID core driver
[ 1.017593] mmcblk0: mmc0:59b4 00000 14.9 GiB
[ 1.020758] platform-mhu c883c404.mailbox: Platform MHU Mailbox registered
[ 1.026199] mmcblk0: p1
[ 1.036252] meson-audio-core c1105400.audio: Failed to create c1105400.audio debugfs directory
[ 1.044385] NET: Registered protocol family 17
[ 1.047275] 9pnet: Installing 9P2000 support
[ 1.051488] Key type dns_resolver registered
[ 1.056089] registered taskstats version 1
[ 1.059740] Loading compiled-in X.509 certificates
[ 1.072266] meson-drm d0100000.vpu: Queued 3 outputs on vpu
[ 1.072466] meson-drm d0100000.vpu: Failed to create d0100000.vpu debugfs directory
[ 1.079844] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
[ 1.086439] [drm] No driver support for vblank timestamp query.
[ 1.120134] meson-dw-hdmi c883a000.hdmi-tx: Detected HDMI TX controller v2.01a with HDCP (meson_dw_hdmi_phy)
[ 1.124731] meson-dw-hdmi c883a000.hdmi-tx: registered DesignWare HDMI I2C bus driver
[ 1.132672] meson-drm d0100000.vpu: bound c883a000.hdmi-tx (ops meson_dw_hdmi_ops)
[ 1.156480] mmc1: new HS200 MMC card at address 0001
[ 1.157254] mmcblk1: mmc1:0001 S10016 14.6 GiB
[ 1.157839] mmcblk1boot0: mmc1:0001 S10016 partition 1 4.00 MiB
[ 1.158425] mmcblk1boot1: mmc1:0001 S10016 partition 2 4.00 MiB
[ 1.158564] mmcblk1rpmb: mmc1:0001 S10016 partition 3 4.00 MiB, chardev (244:0)
[ 1.187427] Console: switching to colour frame buffer device 90x36
[ 1.236042] meson-drm d0100000.vpu: fb0: frame buffer device
[ 1.242083] [drm] Initialized meson 1.0.0 20161109 for d0100000.vpu on minor 0
[ 1.249157] libphy: mdio_mux: probed
[ 1.252949] libphy: mdio_mux: probed
[ 1.258171] xhci-hcd xhci-hcd.0.auto: xHCI Host Controller
[ 1.261415] xhci-hcd xhci-hcd.0.auto: new USB bus registered, assigned bus number 1
[ 1.269406] xhci-hcd xhci-hcd.0.auto: hcc params 0x0228f664 hci version 0x100 quirks 0x02010010
[ 1.277658] xhci-hcd xhci-hcd.0.auto: irq 35, io mem 0xc9000000
[ 1.284050] hub 1-0:1.0: USB hub found
[ 1.287210] hub 1-0:1.0: 2 ports detected
[ 1.291369] xhci-hcd xhci-hcd.0.auto: xHCI Host Controller
[ 1.296595] xhci-hcd xhci-hcd.0.auto: new USB bus registered, assigned bus number 2
[ 1.304183] xhci-hcd xhci-hcd.0.auto: Host supports USB 3.0 SuperSpeed
[ 1.310769] usb usb2: We don't know the algorithms for LPM for this host, disabling LPM.
[ 1.319129] hub 2-0:1.0: USB hub found
[ 1.322482] hub 2-0:1.0: config failed, hub doesn't have any ports! (err -19)
[ 1.330805] scpi_protocol scpi: SCP Protocol legacy pre-1.0 firmware
[ 1.346839] asoc-simple-card sound: i2s-hifi <-> meson-i2s-dai.1.auto mapping ok
[ 1.350096] hctosys: unable to open rtc device (rtc0)
[ 1.353770] ALSA device list:
[ 1.356521] #0: meson-gx-preview
[ 1.746032] EXT4-fs (mmcblk0p1): recovery complete
[ 1.825348] EXT4-fs (mmcblk0p1): mounted filesystem with ordered data mode. Opts: (null)
[ 1.827917] VFS: Mounted root (ext4 filesystem) on device 179:1.
[ 1.847478] devtmpfs: mounted
[ 1.848694] Freeing unused kernel memory: 448K
[ 1.913012] random: fast init done
[ 2.563609] udevd[164]: starting version 3.2.5
[ 2.579649] random: udevd: uninitialized urandom read (16 bytes read)
[ 2.582210] random: udevd: uninitialized urandom read (16 bytes read)
[ 2.586889] random: udevd: uninitialized urandom read (16 bytes read)
[ 2.634465] udevd[165]: starting eudev-3.2.5
[ 2.699294] meson-gx-mmc d0070000.mmc: allocated mmc-pwrseq
[ 2.715439] Registered IR keymap rc-empty
[ 2.715540] rc rc0: meson-ir as /devices/platform/soc/c8100000.bus/c8100580.ir/rc/rc0
[ 2.722414] input: meson-ir as /devices/platform/soc/c8100000.bus/c8100580.ir/rc/rc0/input0
[ 2.732433] meson-ir c8100580.ir: receiver initialized
[ 2.749090] mmc2: new high speed SDIO card at address 0001
[ 62.972026] udevd[165]: worker [180] /devices/platform/soc/d0000000.apb/d0074000.mmc/mmc_host/mmc1/mmc1:0001/block/mmcblk1/mmcblk1boot0 is taking a long time
[ 62.980785] udevd[165]: worker [179] /devices/platform/soc/d0000000.apb/d0074000.mmc/mmc_host/mmc1/mmc1:0001/block/mmcblk1/mmcblk1boot1 is taking a long time
[ 122.873918] EXT4-fs (mmcblk0p1): re-mounted. Opts: (null)
[ 123.408391] urandom_read: 3 callbacks suppressed
[ 123.408403] random: dd: uninitialized urandom read (512 bytes read)
[ 123.573779] meson8b-dwmac c9410000.ethernet eth0: device MAC address 1e:84:7b:c8:84:92
[ 123.653204] Meson GXL Internal PHY 0.e40908ff:08: attached PHY driver [Meson GXL Internal PHY] (mii_bus:phy_addr=0.e40908ff:08, irq=37)
[ 123.671388] meson8b-dwmac c9410000.ethernet eth0: PTP not supported by HW
[ 132.998350] random: dbus-daemon: uninitialized urandom read (12 bytes read)
[ 133.009468] random: dbus-daemon: uninitialized urandom read (12 bytes read)
[ 133.264489] random: sshd: uninitialized urandom read (32 bytes read)
[ 133.341799] NET: Registered protocol family 10
[ 133.342860] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
[ 133.346712] Segment Routing with IPv6
[ 184.262682] random: crng init done

btw: my sdcard is bad.

from meta-meson.

It does seem to detect the phy, although the irq number looks wrong to me. When looking at dmesg logs of others the irq number is often reported as -1 for the internal phy.

This is what I get:

[ 123.653204] Meson GXL Internal PHY 0.e40908ff:08: attached PHY driver [Meson GXL Internal PHY] (mii_bus:phy_addr=0.e40908ff:08, irq=37)

I have added some printk's in the stmmac driver when trying to debug. This is part of the dmesg from that debug:

[ 2.269594] meson8b-dwmac c9410000.ethernet: PTP uses main clock
[ 2.270116] meson-ir c8100580.ir: receiver initialized
[ 2.277143] meson8b-dwmac c9410000.ethernet: no reset control found
[ 2.288167] stmmac - user ID: 0x11, Synopsys ID: 0x37
[ 2.291823] meson8b-dwmac c9410000.ethernet: Ring mode enabled
[ 2.297568] meson8b-dwmac c9410000.ethernet: DMA HW capability register supported
[ 2.305005] meson8b-dwmac c9410000.ethernet: Normal descriptors
[ 2.310907] meson8b-dwmac c9410000.ethernet: RX Checksum Offload Engine supported
[ 2.318331] meson8b-dwmac c9410000.ethernet: COE Type 2
[ 2.323507] meson8b-dwmac c9410000.ethernet: TX Checksum insertion supported
[ 2.330483] meson8b-dwmac c9410000.ethernet: Wake-Up On Lan supported
[ 2.336894] meson8b-dwmac c9410000.ethernet: Enable RX Mitigation via HW Watchdog Timer
[ 2.344929] libphy: stmmac: probed
[ 2.349005] libphy: mdio_mux: probed
[ 2.364768] mmc2: new high speed SDIO card at address 0001
[ 2.380992] libphy: mdio_mux: probed
[ 2.443352] EXT4-fs (mmcblk0p1): re-mounted. Opts: (null)
[ 3.171161] meson8b-dwmac c9410000.ethernet eth0: device MAC address 7e:87:3c:81:4f:61
[ 3.232289] mdio read addr: 8 , 0
[ 3.232529] mdio read finished data:
[ 3.232644] 4096
[ 3.248036] mdio read addr: 8 , 1
[ 3.248408] mdio read finished data:
[ 3.248509] 30729
[ 3.251134] mdio read addr: 8 , 0
[ 3.253321] mdio read finished data:
[ 3.256456] 4096
[ 3.260428] mdio read addr: 8 , 29
[ 3.261771] mdio read finished data:
[ 3.265042] 0
[ 3.268744] Meson GXL Internal PHY 0.e40908ff:08: attached PHY driver [Meson GXL Internal PHY] (mii_bus:phy_addr=0.e40908ff:08, irq=37)
[ 3.294756] meson8b-dwmac c9410000.ethernet eth0: PTP not supported by HW
[ 3.296459] mdio read addr: 8 , 4
[ 3.296664] mdio read finished data:
[ 3.299246] 481
[ 3.302900] mdio read addr: 8 , 1
[ 3.306643] mdio read finished data:
[ 3.307768] 30729
[ 3.311332] mdio read addr: 8 , 0
[ 3.314330] mdio read finished data:
[ 3.316561] 4096
[ 3.320027] mdio read addr: 8 , 1
[ 3.321975] mdio read finished data:
[ 3.325136] 30729

how to read the debug printk's:
In the example below is 8 the address (This is correct and in accordance with dtb-bindings) and 0 is the register being read. 4096 is the integer value that was read at the register.
mdio read addr: 8 , 0
mdio read finished data:
4096

@superna9999 Can you confirm if these mdio read results are correct?

from meta-meson.

I may have found where the problem is. I think mainline u-boot on this board does not set the ethernet phy up properly.

In the beginning I was unable to get a mainline kernel booting with the vendor u-boot that was installed on the internal mmc of the device. That's why I started working with a mainline u-boot from the start.

But trying to solve the not working ethernet got me to try a lot of different things. Just now I discovered that when I build an amlogic u-boot(that did happen to boot a mainline kernel) and wrote that to the sdcard(overwriting mainline u-boot) with mainline kernel on it that ethernet did work.

from meta-meson.

Hi,

We usually don't change the U-boot from actual products, only from SBCs and reference designs since we have the source code.

We may be missing some init in mainline u-boot, we should investigate.

from meta-meson.

I have found the bug in mainline u-boot that prevents the phy from working with an p212 board.

The following code only gets executed if "flags" is not zero:
https://github.com/u-boot/u-boot/blob/11ed312896c5f5814064c5d45dcb2f53dc121437/arch/arm/mach-meson/eth.c#L37-L42

However in the board init code flags is set to zero:
https://github.com/u-boot/u-boot/blob/11ed312896c5f5814064c5d45dcb2f53dc121437/board/amlogic/p212/p212.c#L32

Therefore the code is not executed and the internal GXL RMII PHY is not working.

from meta-meson.

Flags is not set to zero in the board files for khadas-vim and libretech-cc. These board files set flags to "MESON_GXL_USE_INTERNAL_RMII_PHY". I have tested if doing this for p212 works and this indeed solves the not working PHY.

The odroid-c2 and nanopi-k2 set flags to zero as well. It stands to reason that the PHY is also not working with current code on these boards.

Would you like me to make a pull request (for which boards?) with mainline u-boot?

BTW: MESON_GXL_USE_INTERNAL_RMII_PHY requirement in following code seems to not really matter:
https://github.com/u-boot/u-boot/blob/11ed312896c5f5814064c5d45dcb2f53dc121437/arch/arm/mach-meson/eth.c#L37-L42

If you remove flags but leave MESON_GXL_USE_INTERNAL_RMII_PHY requirement then the code gets executed, despite never setting MESON_GXL_USE_INTERNAL_RMII_PHY.

MESON_GXL_USE_INTERNAL_RMII_PHY just gets substituted with 1, so flags is what matters:
https://github.com/u-boot/u-boot/blob/94905e1db8d8d42c4f39f14dbee2f9788390db5e/arch/arm/include/asm/arch-meson/eth.h#L14

from meta-meson.

Hi, you are right it’s a stupid error of mine... it should be fixed upstream and backported to meta-meson. Do you know how to submit a fix to uboot upstream ?

from meta-meson.

I have not submitted a patch to u-boot before but I would like to try.

Should the patch add the change for odroid-c2 and nanopi-k2 as well? These are s905 boards with internal gigabit phy's so I don't know if they need this change as well.
EDIT: I don't believe the odroid-c2 and nanopi-k2 need the change. They use RGMII cause RMII doesn't even allow for gigabit..

from meta-meson.

Exact, The fix is only for p212, odroid-c2 and nanopi k2 are s905 SoC without internal phy and they use an external rgmii phy

from meta-meson.

Fixed with d8d2076

from meta-meson.