Underlying THREE.js version is broken for Chromium about moonrider HOT 11 OPEN

Thanks so much for the heads up and pointing to the solution. I took the PR and deployed it. After a quick test everything seems to work. If it doesn't stick I'll go for the more surgical approach. Let me know if it works you.

from moonrider.

Looks like it worked for me as well.

from moonrider.

Yeah we hit that also in the Chromium port of Wolvic.

from moonrider.

I reverted the update to A-Frame 1.3.0 due to regressions from updating THREE. I also patched THREE in the old A-Frame 1.1.0 to capture the gl.makeXrCompatible promise. It's an interim quick hack that hopefully fixes the problem on Chrome and Wolvic

@alcooper91 @svillar Can you give https://moonrider.xyz/ a try and verify everything works as expected? Thanks!

from moonrider.

I reverted the update to A-Frame 1.3.0 due to regressions from updating THREE. I also patched THREE in the old A-Frame 1.1.0 to capture the gl.makeXrCompatible promise. It's an interim quick hack that hopefully fixes the problem on Chrome and Wolvic

@alcooper91 @svillar Can you give https://moonrider.xyz/ a try and verify everything works as expected? Thanks!

Wolvic with Gecko works fine after the revert, thanks!

That said you mention the patch for makeXrCompatible. Not sure if you're talking about mrdoob/three.js#21126 but at least for Wolvic Chromium, what you patched is not enough, we still need a downstream patch for Chromium to start the WebXR session. Looks like this is needed

from moonrider.

I didn't take any of the THREE patches. I just did "gl.makeXRCompatible().then(function () {})" A hack but I think should work around issues for now. My understanding is that capturing the promise is mandatory.

We will bump THREE (A-Frame) properly in the future. There's always a ton of side effects when updating THREE in particular (hence the revert)

from moonrider.

I haven’t had a chance to check Chrome yet, but my understanding is that you’ll need to wait for that promise to resolve before attempting to create the XRWebGLLayer, I’m not sure that capturing the promise is enough. The error dialog in the issue @svillar linked looks like exactly the error from not waiting on the promise, so it’s likely this is still occurring/the hack is insufficient. I’ll hopefully be able to check into this more tomorrow.

from moonrider.

Thanks @alcooper91 @svillar. @Maxmystere found a fix for the keyboard on A-Frame 1.3.0 and now underlying THREE should incorporate the necessary fixes. Can you confirm on your side? Thanks again.

from moonrider.

Thanks @alcooper91 @svillar. @Maxmystere found a fix for the keyboard on A-Frame 1.3.0 and now underlying THREE should incorporate the necessary fixes. Can you confirm on your side? Thanks again.

It seems to work indeed, however there is now a visual artifact when hovering a letter. See screenshot

from moonrider.

Did not test the keyboard; but confirmed the experience launches for us.

from moonrider.

Thanks for giving it a try

from moonrider.