Do not discard non-component properties when using primitives about aframe-react HOT 8 CLOSED

Possibly similar to #49

from aframe-react.

Ah, that's a nasty bug.

There should be like AFRAME.primitives['a-box'].mappings, but maybe we can just skip that check altogether?

from aframe-react.

The objects stored at AFRAME.primitives.primitives['a-box'] seem to only be the constructor, although geometries expose their schema AFRAME.geometries.box.schema which could get us close to just acknowledging valid properties (since Aframe handles the mapping anyway), but this would only work for primitives based on geometry, not things like <a-cursor> or <a-camera>. I'll hack on some solutions

from aframe-react.

Might be simple to remove the check for invalid properties. A-Frame will handle raising warnings about that.

from aframe-react.

instead of returning an <Entity /> the library could just return a React.createElement, that way there's no prop proxying needed. Essentially treating the primitive as a normal dom element.

see: jsantell/aframe-react-components#1

from aframe-react.

Primitives can also take components, which needs the layer of serialization that converts objects passed as props to strings that HTML can understand.

from aframe-react.

that's right...

from aframe-react.

Fixed in v4.0.x. Nothing being discarded now, everything is sent thru .setAttribute().

from aframe-react.