Giter Club home page Giter Club logo

Comments (5)

jonasfj avatar jonasfj commented on May 18, 2024

Thoughts? I suspect it something we can quickly write..

from aframe-react.

ngokevin avatar ngokevin commented on May 18, 2024

Thanks for feedback. They don't need to be wrapped with React do they? They are usable as DOM elements

from aframe-react.

jonasfj avatar jonasfj commented on May 18, 2024

Sure, but if the <Scene> tag is made with react... We need a react wrapper right?

import {Scene, Entity} from 'aframe-react';

let f = props => {
  return (
    <Scene>
      <a-assets></a-assets>
    </Scene>
  );
}

isn't valid JSX as a-assets isn't defined. Also probably can't be, as it's not a valid JS identifier.

from aframe-react.

ngokevin avatar ngokevin commented on May 18, 2024

custom elements work fine with react now, it'll just do a createElement.

we don't need a react wrapper, even if the Scene is a React Component. The Scene is a React Component because it does serialization to A-Frame for A-Frame components

from aframe-react.

samburgers avatar samburgers commented on May 18, 2024

Is this the correct way to go about adding an image to the Sky component via a-assets ?

render () {
    return (
        <Scene>
            <a-assets>
                <img id="my-image" src="assets/images/my-image.png" />
            </a-assets>
            <Sky src="#my-image"></Sky>
        </Scene>
    )
}

from aframe-react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.