Expand shell commands about xshe HOT 5 CLOSED

It looks like we need to escape character's ourselves. Instead of worrying about "undoing" the escaping of characters written in a TOML string, we can just use raw TOML strings, which are strings with single quotes (') instead of double quotes (").

We can then write a program to recognize \) as escaping a closing bracket, because \ doesn't escape anything in the TOML representation.

This is a breaking change. We can't really do that much about this. We could try to detect the type of quotations that are used, but that would involve parsing the file and might trigger some false positives (this might be worth it though, if we state that these false positives can happen). Otherwise, the documentation should be changed to use single quotes, and it should be directly stated that using double quotes requires double escaping.

from xshe.

However, this finally allows us to implement this feature! When this is completed, we can also easily finish the rest of #38.

from xshe.

To be able to issue warnings, we can read through each line of the file and scan for any line that matches /^[A-Za-z0-9\._]+\s*=\s*\[?\s*"/m. If we find any, we will display a warning that recommends switching to single quotes.

from xshe.

Also note that the use of double quotes with never be removed, just discouraged for most use cases. This is because after this issue is implemented and merged the new behavior will normally result in having to double escape backslashes while using double quotes.

The warning will either be downgraded it severity or removed in a future version a significant amount of time after the changes in this issue are made. This will probably happen in v1.0.0.

from xshe.

Update: Warnings will not be issued as that could affect actual use cases.

from xshe.