Giter Club home page Giter Club logo

Comments (7)

ferrarimarco avatar ferrarimarco commented on June 3, 2024 1

I was able to reproduce this. #5499 should fix the bug :)

Thanks for reporting!

from super-linter.

ferrarimarco avatar ferrarimarco commented on June 3, 2024

Hi! Thanks for reporting this.

Since super-linter v6, JSCPD lints the entire code base and not individual files.

That snippet that you reference is to handle testing that particular linter and it's not needed otherwise.

PS: TEST_CASE_RUN default to false already:

TEST_CASE_RUN="${TEST_CASE_RUN:-"false"}"

from super-linter.

ccolella-mdc avatar ccolella-mdc commented on June 3, 2024

Sure but when I run it without a value for TEST_CASE_RUN JSCPD doesn’t run at all. When I run it with TEST_CASE_RUN: false it does run.

I should not have to include TEST_CASE_RUN to run JSCPD.

from super-linter.

ferrarimarco avatar ferrarimarco commented on June 3, 2024

Sure but when I run it without a value for TEST_CASE_RUN JSCPD doesn’t run at all. When I run it with TEST_CASE_RUN: false it does run.

I should not have to include TEST_CASE_RUN to run JSCPD.

This is correct. Also, when you TEST_CASE_RUN=true, JSCPD runs in a way that checks duplicates within each file, which is not likely what you want.

Can you include the full debug log, not just a fragment, so we can see what's going on?

from super-linter.

ccolella-mdc avatar ccolella-mdc commented on June 3, 2024

TEST_CASE_RUN is not documented as a required input. If it is required the docs should say so.

Here's the full log file

super-linter.log

from super-linter.

ferrarimarco avatar ferrarimarco commented on June 3, 2024

Let me reopen this while we investigate.

On line 1814, the process to build the file list terminates successfully, but it doesn't seem to print the expected log line about JSCPD:

# JSCPD test cases are handled below because we first need to exclude non-relevant test cases
if [[ "${TEST_CASE_RUN}" == "false" ]]; then
debug "Add ${FILE} to the list of items to lint with JSCPD"
echo "${FILE}" >>"${FILE_ARRAYS_DIRECTORY_PATH}/file-array-JSCPD"
fi
,

despite TEST_CASE_RUN being false (line 1782 in your log)

from super-linter.

ccolella-mdc avatar ccolella-mdc commented on June 3, 2024

Awesome thank you! And of course

from super-linter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.