Giter Club home page Giter Club logo

Comments (7)

pdiniz13 avatar pdiniz13 commented on May 25, 2024

This https://github.com/supasate/test-react-router-redux seems to be working fine. So i'm not sure whats the difference between the two

from connected-react-router.

Elyx0 avatar Elyx0 commented on May 25, 2024

@pdiniz13 The repo you mentionned contains "react-router-redux": "^4.0.8" and doesn't leverage connected-react-router. I'm also not sure which way is the best way to go between the two. Maybe @supasate would know

from connected-react-router.

supasate avatar supasate commented on May 25, 2024

Hi @pdiniz13, could you provide me more detail?

  • When does it crash? (initial load, change location, etc)
  • Could you provide me a minimal repo causing such error? I tried upgrading react-router to v4.0.0 and it still works fine.

Thanks!

Note: This repo https://github.com/supasate/test-react-router-redux is for testing the new react-router-redux. I tested it locally with yarn link, so, the version of react-router-redux in package.json does not mean anything there.

from connected-react-router.

supasate avatar supasate commented on May 25, 2024

I just released v4.0.0 (out of beta) which uses [email protected]. The examples are also updated to use the latest release.

@pdiniz13 If you still face the problem, please let me know. (A minimal repo that reproducing the problem will be appreciated).

from connected-react-router.

Elyx0 avatar Elyx0 commented on May 25, 2024

react-router-redux@next has fixed these issues too so I guess it's fine.

from connected-react-router.

pdiniz13 avatar pdiniz13 commented on May 25, 2024

@supasate the issue was that I had upgraded react-router but react-router-dom was still running on beta. Once i upgraded react-router-dom it solved the problem. I think its safe to close this.

from connected-react-router.

supasate avatar supasate commented on May 25, 2024

Good to hear that :)

from connected-react-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.