Comments (6)
I never try react-async-component
also. Anyway, great to hear that your problem was solved!
from connected-react-router.
Hi @cescoferraro. I never try redux-observables. I'll check it.
Btw, could you provide a minimal repo that still causes this problem? Thanks!
from connected-react-router.
@supasate here its the branch I tried to hook up the connected-router.
https://github.com/cescoferraro/flag/compare/feature/connected-react-router?expand=1
Do you have a jsbin template I can try to reproduce this?
from connected-react-router.
its seems that it breaks here
connected-react-router/src/middleware.js
Line 14 in fa53a62
from connected-react-router.
@supasate But the cause it most likely to be this
@@router/LOCATION_CHANGE get fired twice by this simple button
import {push} from "connected-react-router";
@reduxForm({form: 'loginForm'})
@connect((state) => ({app: state.app}), AppActions)
export class LoginComponent extends React.Component<any, any> {
render() {
...
<button onClick={()=>{
this.props.dispatch(push("/dashboard/workers"))
this.props.dispatch({type:"PONG"})
}}>HELLO
</button>
}
}
from connected-react-router.
The issue here is this
https://github.com/ctrlplusb/react-async-component#server-side-rendering-application
withAsyncComponents renders the the whole app twice to do some optimizations (??), but removing it from the client side didnt seem to bother my async component what so ever. So problem solved.
now I get to use redux-observables and write cool epics
import { ajax } from 'rxjs/observable/dom/ajax';
import { push } from 'connected-react-router'
const fetchUser = username => ({ type: FETCH_USER, payload: username });
const fetchUserEpic = action$ =>
action$.ofType(FETCH_USER)
.mergeMap(action =>
ajax.getJSON(`https://api.github.com/users/${action.payload}`)
.map(response => push(`/dashboard/${action.payload}`))
);
dispatch(fetchUser('torvalds'));
from connected-react-router.
Related Issues (20)
- Missing typing for the default component property `children` for react@17 HOT 1
- Can't install package with React 18.1 HOT 5
- `history.replace` is not working after upgrading to 6.9.2 version HOT 1
- Type '{ children: () => Element; history: History<unknown>; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<ConnectedRouter<unknown>> & Readonly<ConnectedRouterProps<unknown>>'. HOT 5
- Add support for react-redux v8.0.2
- Support [email protected] HOT 1
- Is connected-react-router compatible with react 18? HOT 8
- This project appears to be out of maintenance HOT 3
- Upgrade peer dependencies to support React 18 HOT 1
- When will support react@18 & [email protected] & [email protected] HOT 1
- Incompatibility with history.listen with history@5
- Will support react-router v6 and history v5? HOT 2
- Redirect not working in react-router-dom v6 HOT 1
- Expose an Error Handler
- How to reset the states with connect-react-router HOT 1
- VSCode - Integrated Console stops responding
- When will the support come for react@18? HOT 2
- Is the project DEAD??? HOT 2
- link button not working second when i added new maincategory, it is rendering same component intead of going path
- When will the support come for react@18? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from connected-react-router.