Using with Immutable.js about connected-react-router HOT 9 CLOSED

Hi all, I've made it support Immutable.js already in the 4.0.0-beta.3 release.

Just import ConnectedRouter, routerMiddleware and connectRouter from connected-react-router/immutable.

See more details here.

from connected-react-router.

I never try with Immutable.js yet. Is there anything that can affect the result?

from connected-react-router.

I was playing around with Immutable.js this weekend so I decided to give this a try.

You can see an example of how this would work w/ Immutable in my fork: https://github.com/ecozoic/connected-react-router/pull/1/files

These changes assume your entire state object is an Immutable iterable (so if you use combineReducers that means you are using a library like redux-immutable). I've seen examples where the state object itself is mutable but all of its top level properties are immutable iterables. Implementation for something like that would be slightly different.

This is just a POC, to do something for real we would want this to be configurable somehow. Primary changes are in the ConnectedRouter where we read values from the store and in the connectRouter/routerReducer where we actually update state. Could maybe provide an "immutable" option on the router/middleware or more generally allow consumers to pass in some functions as props/arguments to customize behavior.

from connected-react-router.

Thanks @ecozoic. I understand it now. I may provide useImmutable option to make it simple to use. (If you would like to submit a PR, it is welcome!)

I'm not sure how often people use other ways to select value from the state object. So, I may provide an option to specify selector function in the future if there are several requests on this feature.

from connected-react-router.

I had made my own fork of this project supporting ImmutableJS, but it would be kind of stupid to make a separate PR when @ecozoic works wonders already! Great work.

I was wondering what the best API would be if you would support Immutable out of the box? One example is redux-form, eg it has 2 ways to import things;

import { Field } from 'redux-form'
import { Field } from 'redux-form/immutable'

It uses a factory function to create the correct type. Maybe the same principle can be used here?

from connected-react-router.

@nickwaelkens I like the way redux-form did. I might go that path.

from connected-react-router.

Great work @supasate. Will try this out soon but looks good!

from connected-react-router.

Yes thanks so much @supasate ! Adding this to my react-starter and it seems to be working great!

EDIT - here's a PR w/ changes to support it. super easy!
https://github.com/ecozoic/react-starter/pull/39/files

from connected-react-router.

@ecozoic Cool! Great to know it works for you!

from connected-react-router.