Giter Club home page Giter Club logo

Comments (4)

abc3 avatar abc3 commented on May 13, 2024 1

what happens if Supavisor can't establish a connection to the db? i.e. the password both the user used and that's stored in tenants turns out to be incorrect?

Hmm, yeah, that behavior creates an infinite loop in the db_handler until the manager kills the connection tree 🤦‍♂️
I'll fix this and make it more robust in a separate PR

from supavisor.

abc3 avatar abc3 commented on May 13, 2024

Thanks for reporting! For our internal needs, we want to allow connections even if the database is not responding. However, it, of course, sucks if the client fails on a cold start, especially when it's Postgrex.

As a potential solution, I suggest adding a wait timeout. During this period, if we receive parameter_status from the database, we can forward it to the client, or alternatively, send a "stub" packet with a server version of 0.0.
I prepared a small fix #101, WDYT?

cc @chasers

from supavisor.

acco avatar acco commented on May 13, 2024

@abc3 Just took a look at your PR -- looks like a great solution! This feels right to me. I just ran some tests against your branch and it worked great.

Tangential question: what happens if Supavisor can't establish a connection to the db? i.e. the password both the user used and that's stored in tenants turns out to be incorrect?

from supavisor.

abc3 avatar abc3 commented on May 13, 2024

Could you take a look at #114 fix? It will stop the DbHandler retries, and the next client connection attempt will relaunch the pools with the correct credentials

from supavisor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.