Giter Club home page Giter Club logo

Comments (11)

akar016012 avatar akar016012 commented on June 24, 2024 1

Or simple fix would be to just correct this type -mb-48 to mb-48.

from supabase.

pasimuno-ako avatar pasimuno-ako commented on June 24, 2024 1

Actually, looking at the other pages beyond Database and Auth, it looks like the website is not consistent with when the code blocks get cut off by the section divider, so your solution may be adequate.

from supabase.

Hallidayo avatar Hallidayo commented on June 24, 2024

Hi @pasimuno-ako - Thank you for opening, feel free to open a PR for a fix.

from supabase.

H0onnn avatar H0onnn commented on June 24, 2024

@Hallidayo @pasimuno-ako Hello ! Can I solve this issue ?

from supabase.

Hallidayo avatar Hallidayo commented on June 24, 2024

@H0onnn - of course! feel free to open a pull request.

from supabase.

akar016012 avatar akar016012 commented on June 24, 2024

I have fixed the issue and opened a new pull request

image
image

#26495

from supabase.

pasimuno-ako avatar pasimuno-ako commented on June 24, 2024

@akar016012 Your solution works but is not ideal because adding the mt-20 simply negates the -mb-48 from the section above.

The ideal solution is to either remove the -mb-48 or add a new class to that element sm:mb-0 because it seems the negative margin is still being used on smaller screens (based on other pages' designs), but on desktop, the height of the text next to the code block are taller, so they get cut off.

from supabase.

pasimuno-ako avatar pasimuno-ako commented on June 24, 2024

Or simple fix would be to just correct this type -mb-48 to mb-48.

No, because the negative margin is only used for small screens to achieve the effect of the code blocks being cut off by the next section's margin like this:

Screenshot 2024-05-17 at 12 46 53 PM

Which are also done on other pages without issues like in the Database page:

Screenshot 2024-05-17 at 12 49 01 PM

I updated my ideal solution recommendation in my previous comment above.

from supabase.

akar016012 avatar akar016012 commented on June 24, 2024

Yes, so I fixed the typos in two places and it makes the mobile view even better

Before:
image

After:
image

from supabase.

Muhammad-Owais-Warsi avatar Muhammad-Owais-Warsi commented on June 24, 2024

Can i work on this issue ??

from supabase.

H0onnn avatar H0onnn commented on June 24, 2024

@Muhammad-Owais-Warsi This issue has already opened PR

from supabase.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.