magic link: improve responses about auth HOT 6 CLOSED

OK, I''ll try to do it today =)

from auth.

@awalias as far as i understand you want just standardise answers and add to magic link response empty json answer?

from auth.

if successful the response should just be {}

if MaxFrequency is broken then we should probably return an error with 429 response code

the problem is we need to suppress the json response from the SignUp method here and here

from auth.

@awalias in cases when SignUp method respond with some error - do we need show same error which reterned from that method?
I have one option for dealing with response from SignUp method. Just implement struct, that fits Response interface and handle response.
For example:
Response stub code

type responseStub struct {
}

func (rw *responseStub) Header() http.Header {
	return nil
}

func (rw *responseStub) Write(data []byte) (int, error) {
	return 0, nil
}

func (rw *responseStub) WriteHeader(statusCode int) {
}

Magic link code

...
if config.Mailer.Autoconfirm {
	// signups are autoconfirmed, send magic link after signup
	if err := a.Signup(fakeResponse, r); err != nil {
		// TODO: handle error
		w.Write(nil)
	}
	newBodyContent := `{"email":"` + params.Email + `"}`
	r.Body = ioutil.NopCloser(strings.NewReader(newBodyContent))
	r.ContentLength = int64(len(newBodyContent))
	return a.MagicLink(fakeResponse, r)
}
// otherwise confirmation email already contains 'magic link'
if err := a.Signup(w, r); err != nil {
	// TODO: handle error
	w.Write(nil)
}

return sendJSON(w, http.StatusOK, make(map[string]string))
....

I'm not sure that this solution is "good". What do you think about that?

from auth.

I think it's ok, If you want to make a PR I can test it out today 👍

from auth.

nice one @icecream78 !!

from auth.