Giter Club home page Giter Club logo

Comments (7)

SunnyLi avatar SunnyLi commented on July 16, 2024

videojs 5.0 made many internal API changes which is what caused this breakage since videojs.Button was part of the internal API that really shouldn't have been used..

For now the latest videojs 4.x version should still work and I will eventually update this plugin to support videojs 5.x in the near future.

from videojs-ass.

SunnyLi avatar SunnyLi commented on July 16, 2024

If losing the ability to toggle subtitle visibility is not a major concern (so that subtitle will always be visible), then you can disable the toggle button creation step so that this plugin will continue to work on videojs 5.0.

from videojs-ass.

smad2005 avatar smad2005 commented on July 16, 2024

Thank you

from videojs-ass.

anonym24 avatar anonym24 commented on July 16, 2024

video.js 5 also has the Responsive Sizing feature ( data-setup='{"fluid":true} ), but if it's enabled subtitles aren't shown correctly.
Is it possible to fix it? (it is has to understand the new values for width and height)

from videojs-ass.

SunnyLi avatar SunnyLi commented on July 16, 2024

Sorry for the late response. I'm working on updating the plugin to support videojs 5.x now (so that the button doesn't break the plugin initialization) and will see if I can also get responsive sizing to work. It'll probably be put in a v5.x branch since it will definitely break videojs 4.x support.

from videojs-ass.

SunnyLi avatar SunnyLi commented on July 16, 2024

I've released v0.5 which adds support for videojs 5.x and some partial support for fluid mode.

from videojs-ass.

smad2005 avatar smad2005 commented on July 16, 2024

Thanks, my issue has resolved. 7308ab5

from videojs-ass.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.