[Proposal] Default outputs via `output_of` actor class method about actor HOT 3 CLOSED

Thanks for the response!

I appreciate your concerns, the initial implementation was indeed rudimentary. I was already working on the more sophisticated implementation in #152, and I think it addresses almost all of your concerns, so went ahead and opened it.

• Supports play by returning the return value of the final actor in the chain.
• Supports fail!, as it raises normally when an actor or play chain actor fails.
• Supports rollback, though like call it will raise an error, and to access the failed actor state one still needs to use result.
  • I have a notion to add something like a last_rollback_value option, though I think this use case is niche enough that using result suffices.

By single type signature, I understand you to mean that call and result both return a ServiceActor::Result. I'll suggest that output_of is purely additive, it still leverages results, doesn't impinge on existing functionality, and just streamlines the accessing of result.explicit_output.

from actor.

Hi there! Thank you for bringing up this suggestion 🤗

While I understand the need for a more streamlined syntax I don’t think this is a good fit for the gem as it doesn’t work well with the idea of a single type of signature for actors, doesn’t allow for actors to be used in play and pass their outputs from one to the other, doesn’t allow for the fail! and rollback mechanisms.

While I think this is fine as a monkey-patch I’d rather not support it fully by adding this in the gem. As an extra precaution if you are using this I’d suggest adding output :_default_output to your ApplicationActor.

from actor.

Closed by #152. This is now possible using the .value(…) method.

Thanks @llhhaa 👏🏻

from actor.