Comments (9)
simonsmith
commented on July 26, 2024
Agreed, that's not the best word. Would it be more like u-sizeFill?
from components-grid.
timkelty
commented on July 26, 2024
@simonsmith correct, the current version of Grid--fit is equivalent to putting u-sizeFill on every cell.
So maybe Grid--fill, Grid--fit?
from components-grid.
simonsmith
commented on July 26, 2024
If we chose Grid-fill that would keep it inline with the size utilities.
Edit: At first I thought it might be a nice default, but then it could get in the way for people using Grid on small devices
from components-grid.
timkelty
commented on July 26, 2024
Yeah - I think full width cells are still good for encouraging a mobile-first composition.
from components-grid.
timkelty
commented on July 26, 2024
I'm thinking maybe Grid--distribute would be more appropriate? If we wanted to support a "shirinkwrap" grid like the above example, we could repurpose Grid--fit for that.
@simonsmith Do you think we should also repurpose Grid-fit as described?
from components-grid.
simonsmith
commented on July 26, 2024
@timkelty Yes! Totally forgot about that suggestion. Will make another PR
from components-grid.
timkelty
commented on July 26, 2024
@simonsmith I can do this today if you haven't started!
from components-grid.
simonsmith
commented on July 26, 2024
@timkelty By all means, jump on it
from components-grid.
simonsmith
commented on July 26, 2024
Fixed in #53
from components-grid.
Related Issues (20)
- Use a variable for the font-size
- Add gutter modifier
- inherited font sizes HOT 1
- Grids browser Compatibility HOT 4
- Use .css for the import in index.css ? HOT 4
- History.md HOT 2
- Gutter calc to support em/rem HOT 2
- Grid--alignCenter has no effect HOT 2
- Column ordering HOT 3
- Variables defaults should be set at use, not at top of file HOT 2
- Grid defaulting to font-size zero HOT 5
- negative margin makes container larger than it should be HOT 2
- Grid use of negative margins causes horizontal scrolling HOT 5
- Fixed column width + fluid one HOT 2
- Grid / Grid-cel ignores u-sizeFull HOT 3
- Layout broken using `Grid--withGutter`, in IE11 HOT 3
- Drop .Grid-cell HOT 15
- NPM does not contain latest code HOT 3
- Typo in README.md HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from components-grid.