Cancel action makes our repo test badge "failing" about cancel-workflow-action HOT 4 CLOSED

Thanks, how is it different from:

- if: {{ github.ref_name != 'main' }}
  uses: styfle/[email protected]
  with:
          access_token: ${{ github.token }}

Which is what we're currently using and which is not working: https://github.com/tensorflow/datasets/blob/076de8657a32bac79fad46644c1a4ba24e1a8d7b/.github/workflows/pytest.yml#L17

It looks like your solution is only triggering cancel event when the "push" is not the main branch. But it doesn't prevent cancel to cancel actions in the main branch.

For example, a push on branch A will trigger a cancel event, which will cancel the current tests on the main branch. This will make our tests red.

Maybe it would be nice to add some:

- uses: styfle/[email protected]
   with:
       do_not_cancel_branch: 'main'
       access_token: ${{ github.token }}

So the event is triggered on all branch (including main), but never the cancel "main" tests

from cancel-workflow-action.

For update, we ended up not using cancel-action but instead use the native cancel-in-progress feature from Github:

https://github.com/tensorflow/datasets/blob/4adc2b61a8ed6b56c5fc3259f5ccd46d3be3bab2/.github/workflows/pytest.yml#L14

# Cancel in-progress runs for the current workflow if not on the main branch
# (as it mark the unittests as failed).
# Conditionals to concurrent are based on the solution proposed in this link:
# https://github.community/t/concurrency-cancel-in-progress-but-not-when-ref-is-master/194707
concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}-${{ github.ref != 'refs/heads/master' || github.run_number }}
  # Cancel only PR intermediate builds
  cancel-in-progress: ${{ startsWith(github.ref, 'refs/pull/') }}

from cancel-workflow-action.

I use a separate workflow to control the push events that should cancel.

Then pass the workflow ids that should be canceled:

name: Cancel
on:
  push:
    branches:
    - '**'
    - '!main'

jobs:
  cancel:
    name: 'Cancel Previous Runs'
    runs-on: ubuntu-latest
    timeout-minutes: 2
    steps:
      - uses: styfle/[email protected]
        with:
          workflow_id: 849295, 849296, 849297, 849298
          access_token: ${{ github.token }}

from cancel-workflow-action.

It looks like your solution is only triggering cancel event when the "push" is not the main branch. But it doesn't prevent cancel to cancel actions in the main branch.

It does prevent canceling the main branch. The current branch is considered for cancelation here

So if you never run on the main branch then it wont cancel the main branch.

from cancel-workflow-action.