Unable to create legit zip with binary files. about jszip HOT 4 CLOSED

When you generate the zip file, you don't have (yet) the image loaded. Try generating the blobLink.href in the ajax callback, after adding the image file :-)

You also found a bug in JSZip : without any content, the generated file is invalid...

from jszip.

After some tests, I found out that the empty JSZip zip file and an empty zip file generated with zip are exactly the same :

$ hexdump test.zip 
0000000 4b50 0605 0000 0000 0000 0000 0000 0000
0000010 0000 0000 0000                         
0000016

(zip doesn't want to create an empty zip file so I used the zip test.zip deleteme.txt ; zip -d test.zip deleteme.txt trick and I got a nice zip warning: zip file empty)

file doesn't recognize the file type but unzip print a warning : warning [test.zip]: zipfile is empty.
I think the result isn't a bug, just a strange usecase. Maybe we should log a warning when generating an empty zip file ?

from jszip.

You'd better leave it as is, otherwise you'd eventually have to face some fellow who needs empty zip files for some reason and thus needs an option to disable that warning.

from jszip.

Well I feel dumb. Obviously it needs to be in the callback.

Thanks for the quick response.

from jszip.