Giter Club home page Giter Club logo

Comments (6)

dduponchel avatar dduponchel commented on June 29, 2024

Bower looks great, it is a good idea, but :

  • it is not the only dependency manager. Component also uses the component.json file and they are not fully compatible (see bower#39 or the comments in bower#110).
  • we lack a build phase between the commited code and the pulled code. The bower doc says There should only be at most one file per file type in the main list.. That means concatenate(/minify) the js files and commit the result for each commit.
  • JSZip has no version :-)

A solution for the first 2 points is to create a jszip-bower repository (like angular) with a component.json and minified/concatened files, one commit per release of JSZip. We could also try a jszip-release repository with component.json/package.json for bower/component/ender/jam/volo/... but I don't know if that will work.

from jszip.

ravenac95 avatar ravenac95 commented on June 29, 2024

If either of you were at all interested. I took it upon myself to add jszip to bower's component repo. I agree with @dduponchel assessment so I created a jszip-bower repository that includes a minified jszip as well as the unminified jszip files if the user wished to use those instead. I do think we should track versions in JSZip and I'm going to add an issue for it.

Here's the link to the jszip-bower repository: https://github.com/ravenac95/jszip-bower

If any of the original authors would like me to remove this from the bower repo so that JSZip bower can be handled "in house," I would be absolutely willing.

from jszip.

dduponchel avatar dduponchel commented on June 29, 2024

Thanks for the jszip package !

from jszip.

sorich87 avatar sorich87 commented on June 29, 2024

I think this should be reconsidered.

@ravenac95's repository is not up to date. @dduponchel, I think it's better to simply register this repository with Bower instead of a separate one for the following reasons:

  • Bower uses bower.json now and there's no conflict with Component anymore.
  • If you don't want to add a bower.json file, it won't be a problem either since the JSZip doesn't have any dependencies. It will work without a bower.json file.
  • Bower is mostly used with Yeoman and/or Grunt which do the minification so you don't need to include minified files in this repository.
  • JSZip now has versions.

from jszip.

ravenac95 avatar ravenac95 commented on June 29, 2024

@sorich87 is probably right. I've been remiss in updating for a long while as I've transitioned to using component and personal duties have prevented me from keeping up. I can transfer ownership to anyone who'd like to take up the mantel if keeping a separate repo is still the preferred method.

I will, however, update right now.

from jszip.

dduponchel avatar dduponchel commented on June 29, 2024

@sorich87 I think you are right, I reopen the issue ! I will just wait for #74 which will change a lot of things (it splits JSZip into smaller files and adds a build phase).

@ravenac95 thanks again for the repository !

from jszip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.