cannot unset a coupon about stripe-python HOT 5 CLOSED

The API does not accept an empty string for coupon, the correct way to delete a coupon as per the docs is to do customer.delete_discount(), this obviously doesn't work if the coupon hasn't been saved and you are just trying to remove it from the local object.

Originally I thought that customer._retrieve_params held the attributes that were returned from the API and you could therefore use this to distinguish between a property which is being changed and a property which is being added but this was wrong (after retrieving a customer it is empty).

I'm not sure of a good way of fixing this, everything I think of I can think of a case where it won't work or another issue it will introduce. IMO the issue stems from the delete_discount() method and really to delete the discount you should be setting it to None not calling a method but I don't see that changing as it is the same with the other client libraries.

from stripe-python.

@danielchatfield is correct. Setting the coupon to None or "" will not unset the coupon. You'll need to use the delete_discount method.

from stripe-python.

@kyleconroy the issue here is that the coupon was not valid and thus was not saved on the stripe servers. delete_discount fails here.

This is a valid bug.

from stripe-python.

Whoops, thanks @danielchatfield. I misread the beginning of the issue. Yes, this is a valid bug, as it shouldn't be possible to get a customer object into a state where it cannot be saved.

What if we added del support to Stripe objects?

customer.coupon = "invalid"
customer.save()
# InvalidRequestError: No such coupon: invalid

del customer.coupon
customer.save()

from stripe-python.

I haven't tested it, but does delattr work? https://docs.python.org/2/c-api/object.html#c.PyObject_DelAttr

from stripe-python.