`deleted` on Customer not present when object is live about stripe-python HOT 2 CLOSED

Really really sorry for the delay getting back to you - I usually keep an eye on pull requests and have been heads down on an internal project for the last while.

We've built our API libraries so that they extract information from our API's responses rather than having them hard-coded - if you look, id and object are the only hard-coded field names. Ultimately, whether Customer objects have a deleted attribute before they're deleted is an API question, not a bindings one.

I'll take this back to the rest of the team - I think we'd like to rethink how deleted and non-deleted objects are presented over the API, but obviously these kinds of changes can be tricky.

In the mean time, because I don't think this is fundamentally an issue with stripe-python, I'm going to go ahead and close this issue, but I'll make a note to reach out if we change this behavior.

from stripe-python.

Just a +1 @ebroder.

I've been having to use the same getattr(customer, 'deleted', False) incantation after trying the intuitive customer.deleted attribute that you would expect to be False on a live object. The API should serve an identical attribute name for both live and deleted objects that we can boolean compare.

Another irritation is attempting to do customer.delete() on an already deleted Customer.

I can understanding raising an exception if the customer has already been deleted, but in fact it raises an InvalidRequestError (which is not programmatically useful necessarily) AND a bogus message ("No such customer"). In fact, the customer does exist -- it has just been already deleted. So raising an exception like ObjectDeletedException would at least be more useful for try/catch statements -- but I can also see a use case for a wrapper method like stripe.Customer.delete(force=True) which suppresses any error about the customer having previously been deleted.

p2

from stripe-python.