Giter Club home page Giter Club logo

Comments (7)

niallo avatar niallo commented on May 24, 2024

is this still happening after the worker rewrite? it's totally wrong to do this, of course.

from strider-custom.

jaredly avatar jaredly commented on May 24, 2024

oh yeah it still is. We bypass deploy if there's no "deploytarget". But we're taking heroku and making it a separate plugin, so that will be fixed.

from strider-custom.

niallo avatar niallo commented on May 24, 2024

ok, but shouldn't it be a quick fix to always run deploy hooks (not talking about heroku deploy) without heroku config?

from strider-custom.

jaredly avatar jaredly commented on May 24, 2024

But we don't allow a TEST_AND_DEPLOY run to happen if there's no
deploy_target set in the DB.
I think we need some way for plugins to broadcast that they can deploy this
project

On Thu, Aug 15, 2013 at 2:56 PM, niallo [email protected] wrote:

ok, but shouldn't it be a quick fix to always run deploy hooks (not
talking about heroku deploy) without heroku config?


Reply to this email directly or view it on GitHubhttps://github.com//issues/5#issuecomment-22729770
.

from strider-custom.

sveisvei avatar sveisvei commented on May 24, 2024

+1, my use of strider does internal deploy locally on same machine.

from strider-custom.

jaredly avatar jaredly commented on May 24, 2024

fixed by Strider-CD/strider@12c57fc

from strider-custom.

niallo avatar niallo commented on May 24, 2024

awesome @jaredly !

from strider-custom.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.