simple addon example via stremio-core + hyper about stremio-core HOT 6 OPEN

Unless Tide is more stable, we should go with Tower or Hyper; Actix-web might be an overkill and may be pretty unsafe

from stremio-core.

This is a Tide version but it has problems:

• CORS middleware returns bad request if origin header is not passed: http-rs/tide#318
• Tide's performance is nowhere near hyper
• Tide says they're not production ready

https://github.com/Ivshti/stremio-addon

from stremio-core.

there are new options to consider, namely hyper with futures 0.3

from stremio-core.

I'd like to put my two cents into this...

Tide has changed a lot in the past few months. As of today I have to agree that it's still not ready for production yet, but it's getting close. It runs asynchronously using futures 0.3 and CORS will no longer be an issue when this PR gets merged. That being said, I messed around with your old example-addon using a feature version of tide and it turned out pretty well so far.

Hyper is certainly a good choice too as it's gaining popularity and claims to be production ready, but I think you need to consider if you also need the HTTP client that comes with it? It probably depends; if you're sticking to an example addon that does a few basic API calls or something, sure. But if you're planning to extend it to a full SDK (referring to issue #11), I think it's better to leave the HTTP client of choice to the addon developer and keep the SDK crate as less bloated as possible.

from stremio-core.

@sleeyax your SDK is very impressive, thank you for the contribution!

re tide: I'm sure it's rapidly improving; I don't really have the knowledge to say which one is better for our goals, but we've used hyper before (the futures 0.1 versions), and we're using it in production right now - and we're very happy

Also, having a http client is a good thing. But yes, keeping it out is a good call too.

Since all of the dev effort is focused on delivering 5.0, we don't really have the time to develop a Rust SDK.

If you feel yours is mature enough to build something (seems to me that it is), I suggest you submit a PR to add it to https://github.com/Stremio/stremio-addon-sdk/blob/master/docs/examples.md and also to the README (I Suggest a "Rust version" paragraph under "Examples & tutorials", saying something like "There is a third-party Rust version built on stremio-core developed by sleeyax here").

from stremio-core.

@Ivshti

Thanks :)

I'd like to add a few more things and then I'll open that PR you suggested.

from stremio-core.