Support for registering schemas under custom subject about avrora HOT 8 CLOSED

@arttsu Thanks for your help, the #63 is in the master and will be released this week 🤝

from avrora.

Hey, @arttsu thanks for rising this question. In short, I think a better manual schema registration interface definitely a thing to implement, and I would mark it as an enhancement issue.

In specific auto-registration is:

1. Not a best-practice, but more a comprehensive feature when its conventions work for you
2. Many other features require to disable it since by design reader should never register the schema, it's a writer's prerogative
3. AvroTurf is good with some initial ideas, but it's not a good design solution to combine encoding interface with a schema registration, I would rather split the functionalities to follow SRP

WDYT, sounds good?

from avrora.

Just a heads-up about schema registration, this is a sneak-peek for the upcoming functionality

I think it will not be exposed via the main Avrora module due to its specificity (I prefer to keep in Avrora only main flows about encoding/decoding), but can be used directly.

With it, your example can be rewritten as:

defp ensure_registered_schema() do
  {:ok, _} = Avrora.Utils.Registrator.register_schema_by_name(@schema_full_name, as: "#{@topic_name}-value")
end

from avrora.

@Strech, thanks for a thorough response! Glad that better manual schema registration would be on your radar. It would definitely be sufficient for my usecase.

from avrora.

Thanks for working on this, looks great! Very minor nitpick - have you considered using the name Registrar for the new module? To me it seems to be more correct (not a native speaker though, so might be wrong 😄).

from avrora.

@arttsu thanks for the name suggestion, I will definitely look for the better name 👍🏼

from avrora.

@arttsu It takes me a while, but here we are https://github.com/Strech/avrora/releases/tag/v0.16.0 it includes also an updated mix task for schema registrations. I will prepare release notes soon. Thanks for your support 🤝

from avrora.

Awesome! Thanks again for implementing and releasing this so quickly 👍

from avrora.