MQTT retain publishes do not make it to Pulsar about mop HOT 3 CLOSED

It seems like in the Qos0 and Qos1 PublishHandlers the call to addRetainedMessage returns to early or avoids calling writeToPulsarTopic. So it seems retained messages never make it to the destination Pulsar topic because of this. I'd expected addRetainedMessage and writeToPulsar topic to be called for retained messages, as retained messages should still reach Pulsar. This early return seems to prevent messages from reaching Pulsar, and thus prevents the message from reaching all active subscriptions.

See here:

1. mop/mqtt-impl/src/main/java/io/streamnative/pulsar/handlers/mqtt/support/Qos0PublishHandler.java

   Line 38 in 95899c3

   return retainedMessageHandler.addRetainedMessage(msg);

2. mop/mqtt-impl/src/main/java/io/streamnative/pulsar/handlers/mqtt/support/Qos1PublishHandler.java

   Line 51 in 95899c3

   ret = retainedMessageHandler.addRetainedMessage(msg);

from mop.

PR submitted for fix.

from mop.

Bump. This is a pretty major bug in the retain mechanism, and it'd be nice to get this into the next release.

from mop.