Can't get prev/next arrows to work about luminous HOT 7 CLOSED

Hi @frederickfogerty - I've had what I think may be similar issues with the Gallery functionality as @NicholasJohn16 - I'm not entirely sure its working as intended, either locally in my project (standard Luminous lightbox seems fine) nor in codepens I've based on the Lightbox example, modified using Gallery code in the readme.

Here's one of my pens: https://codepen.io/anon/pen/RegwWp

Would it be possible to get an official working codepen of the gallery functionality?

from luminous.

Hey there @NicholasJohn16, sorry to hear that you've had issue with Luminous! This is on my list of issues to look at for the next two weeks. I'll keep this issue updated with my progress.

In the meantime, it would make my job a lot easier if you were able to provide a standalone reproduction of this bug, either on codesandbox or codepen. Do you think you'd be able to do this?

from luminous.

Same issue here

from luminous.

I did eventually get this working, although my code doesn't work in Codepen as its specific to the NPM installation. I'll add what I have below (ES6 as I'm using Babel):

import { Luminous, LuminousGallery } from 'luminous-lightbox';

new LuminousGallery(document.querySelectorAll('.gallery-image'), {
  arrowNavigation: true
},
{
  caption: function (trigger) {
    return trigger.querySelector('img').getAttribute('alt');
  }
});

For me the important bits were to include LuminousGallery in the module import, and to make sure I was using querySelectorAll instead of querySelector, a copy and paste oversight on my part.

If I recall correctly, I also had trouble with the next and prev arrows until I made sure all my image paths were correct and unique, not empty or repeating image paths I was using to test the script.

Hope this helps.

from luminous.

Thanks @hellorich, unfortunately I am using the CDN version, and I wonder if LuminousGallery is included. I don't think it is because I'm using the exact same code as you but I can't get arrowNavigation to work.

If you're using the pre-built version of Luminous, it will automatically make window.Luminous and window.LuminousGallery available for your use when included on your page.

from luminous.

Same issue here, was there any progress on this ?

from luminous.

Hi all. This was a regression from a previous release and is fixed in the PR #121. If you would like to checkout that PR and test that it fixes the problem, that would be much appreciated. Otherwise, sit tight and a fix should be released soon!

from luminous.