Comments (5)
I went ahead and created a pull request, but it seems the new build made some changes to the encapsulation of some functions. I followed the instructions from https://github.com/imgix/luminous/blob/master/CONTRIBUTING.md, so I'm not sure if I missed something. I committed the new dist files separately so they can easily be reverted and build again if necessary.
from luminous.
Odd. I'm going to manually rebuild and merge that in. I'd be interested to know why you're getting different build output, I may need to lock some things down a bit more in package.json. Can you send through the output of a npm list
from your Luminous working dir?
Either way, thanks for the PR! I'll have a new version out with this fix shortly.
from luminous.
Just released 0.2.5! https://github.com/imgix/luminous/releases/tag/0.2.5
from luminous.
Thanks for the fast reply and for merging my PR!
I've attached the output from npm list below.
npm-list.txt
from luminous.
I'm not totally sure what's going on there, but it seems like one of the deps just slightly changed how they output JS with an update. I rm -r
'd my node_modules
and npm install
ed, and now my output matches yours. Everything seems fine though, and the changes are fine by me, so I just went ahead and committed them. Thanks again for the PR, and for sending through your npm list
!
from luminous.
Related Issues (20)
- Separate basic theme and "fullscreen"-esque mode HOT 1
- injectBaseStyles not setting HOT 2
- How to inject captions when using LuminousGallery class HOT 1
- Add option to set caption (suggestion) HOT 2
- I want to give a class name to the enlarged image. HOT 2
- Demo url on documentation leads to 404 error
- Action Required: Fix Renovate Configuration
- is it possible to use luminous in vue.js? HOT 1
- Dependency Dashboard
- Include license in distributed JS HOT 3
- closetrigger? HOT 2
- The image file's height is over when the image is big size HOT 6
- The automated release is failing 🚨
- Keyframe rule ignored due to bad selector. HOT 2
- Small viewport sizes don't scale the image properly HOT 3
- Arrows are not in the vertical center of the image HOT 1
- onChange doesn't work HOT 1
- What is the proper way to import LuminousGallery?
- Direct including a script from CDN (Unpkg, jsDelivr, ...)
- Call for Maintainer(s) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from luminous.