Giter Club home page Giter Club logo

Comments (5)

bertramakers avatar bertramakers commented on June 2, 2024

I went ahead and created a pull request, but it seems the new build made some changes to the encapsulation of some functions. I followed the instructions from https://github.com/imgix/luminous/blob/master/CONTRIBUTING.md, so I'm not sure if I missed something. I committed the new dist files separately so they can easily be reverted and build again if necessary.

from luminous.

paulstraw avatar paulstraw commented on June 2, 2024

Odd. I'm going to manually rebuild and merge that in. I'd be interested to know why you're getting different build output, I may need to lock some things down a bit more in package.json. Can you send through the output of a npm list from your Luminous working dir?

Either way, thanks for the PR! I'll have a new version out with this fix shortly.

from luminous.

paulstraw avatar paulstraw commented on June 2, 2024

Just released 0.2.5! https://github.com/imgix/luminous/releases/tag/0.2.5

from luminous.

bertramakers avatar bertramakers commented on June 2, 2024

Thanks for the fast reply and for merging my PR!
I've attached the output from npm list below.
npm-list.txt

from luminous.

paulstraw avatar paulstraw commented on June 2, 2024

I'm not totally sure what's going on there, but it seems like one of the deps just slightly changed how they output JS with an update. I rm -r'd my node_modules and npm installed, and now my output matches yours. Everything seems fine though, and the changes are fine by me, so I just went ahead and committed them. Thanks again for the PR, and for sending through your npm list!

from luminous.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.