Comments (3)
Good question. We have discussed about that but we do not have clear opinion yet. I'd say that just now it's still good to keep them separate until we have stable API and clear vision what we want.
from strawberry-django.
Because the project is already separate, I don't know if we should devote effort towards migrating the project into the core repository just to later consider making it separate again. I think we should instead work on stabilizing the core API such that keeping strawberry-graphql-django
separate doesn't become a maintenance burden, and that other extensions have a system to work off of.
I don't think it's wise to have a plugin/extension rely on the internals (i.e. not a public API) of the core project, which I think it currently is doing, while also being in a separate repo. If we can create a clear API that external tools can use to extend the library, we can (and imo should) consider keeping them separate.
We can even make use of namespace packages so that strawberry-graphql-django
can still be imported as from strawberry.django import ...
(i.e. under the strawberry
namespace) even if it's a separate package.
That being said, if we do decide to combine the two projects now, it's also not impossible to later split the repo. I've got some experience breaking apart mono repos while maintaining git history, and it's not too difficult if there's a clear directory separation within the repo.
from strawberry-django.
@la4de I think we can close this.
from strawberry-django.
Related Issues (20)
- Enum values in mutation input causes ValidationError HOT 2
- Allow to return custom types on mutations without a related django model
- Self is coroutine - there is no data being awaited. HOT 4
- Nested Perms Results in unecessary queries (N+1?) HOT 4
- Built in create mutation has regressed and is not able to create model instances correctly HOT 2
- `django.db.models.expressions.DatabaseDefault` raises `TypeError: fromisoformat` on mutation HOT 1
- Docs for reference for DjMoney type HOT 5
- ForeignKey `_id` field resolves to relation object, not field value HOT 8
- Returning `bool` from mutation causes exception. HOT 6
- Custom filter/order method unexpected value
- ListConnectionWithTotalCount and filter custom resolver HOT 2
- description and deprecation_reason parameters of enums values not used HOT 4
- Apollo Sandbox doesn't update debug toolbar HOT 2
- Ability to use custom StrawberryDjangoField class for relay connections and nodes HOT 1
- Slow startup when defining many filters HOT 5
- N+1 in some resolvers when enabling `only` extension HOT 2
- The right way to protect and filter information HOT 5
- Thanks! HOT 1
- The get_queryset method is called twice when using relay connections HOT 1
- Custom ordering methods doesn't work when value are passed by variables HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from strawberry-django.