Giter Club home page Giter Club logo

Comments (3)

la4de avatar la4de commented on June 2, 2024

Good question. We have discussed about that but we do not have clear opinion yet. I'd say that just now it's still good to keep them separate until we have stable API and clear vision what we want.

from strawberry-django.

BryceBeagle avatar BryceBeagle commented on June 2, 2024

Because the project is already separate, I don't know if we should devote effort towards migrating the project into the core repository just to later consider making it separate again. I think we should instead work on stabilizing the core API such that keeping strawberry-graphql-django separate doesn't become a maintenance burden, and that other extensions have a system to work off of.

I don't think it's wise to have a plugin/extension rely on the internals (i.e. not a public API) of the core project, which I think it currently is doing, while also being in a separate repo. If we can create a clear API that external tools can use to extend the library, we can (and imo should) consider keeping them separate.

We can even make use of namespace packages so that strawberry-graphql-django can still be imported as from strawberry.django import ... (i.e. under the strawberry namespace) even if it's a separate package.


That being said, if we do decide to combine the two projects now, it's also not impossible to later split the repo. I've got some experience breaking apart mono repos while maintaining git history, and it's not too difficult if there's a clear directory separation within the repo.

from strawberry-django.

joeydebreuk avatar joeydebreuk commented on June 2, 2024

@la4de I think we can close this.

from strawberry-django.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.