Comments (15)
zecanard
commented on August 25, 2024
I actually encountered the same issue recently: I wanted an automation that triggered on every activity, so I set Has location data? ‘Yes’ OR Has location data? ‘No’. The automation failed to trigger on two activities without location data. I chalked it off to my conditions being quirky, so I now use a different condition. But seems there is indeed a bug.
from core.
igoramadas
commented on August 25, 2024
@ichibana can you send me your account ID please? I'll investigate.
from core.
igoramadas
commented on August 25, 2024
More details: the radioboxes to set the "samePropertyOp" is hidden from the UI when there are 2 conditions or less, as it was supposed to use the "op" in these cases instead, regardless if conditions are of the same type or not. But the value was still being pushed and saved on the recipe, even if you can't see it.
In both examples given above, you see OR on the UI but in reality the operator used was AND. Fixed now.
Will be live in production in a few hours.
from core.
ichibana
commented on August 25, 2024
Gotcha! Still need my ID? Thanks for the reply.
…On Sat, May 20, 2023 at 12:18 PM Igor Ramadas ***@***.***> wrote:
***@***.***
<strautomator/web@cabe57a>
More details: the radioboxes to set the "samePropertyOp" is hidden from
the UI when there are 2 conditions or less, as it was supposed to use the
"op" in these cases instead, regardless if conditions are of the same type
or not. But the value was still being pushed and saved on the recipe, even
if you can't see it.
In both examples given above, you see OR on the UI but in reality the
operator used was AND. Fixed now.
Will be live in production in a few hours.
—
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFBLHOV46PO6X3TUEA4BQTDXHEKGXANCNFSM6AAAAAAYIMZJU4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
from core.
igoramadas
commented on August 25, 2024
Not needed, I asked in case you wanted to have it fixed manually before the deployment. But fix is ready in production now. You can simple edit the automation again, and it will automatically set the correct "samePropertyOp" flag.
from core.
ichibana
commented on August 25, 2024
Thank you Igor!
…On Sun, May 21, 2023 at 12:42 PM Igor Ramadas ***@***.***> wrote:
Not needed, I asked in case you wanted to have it fixed manually before
the deployment. But fix is ready in production now. You can simple edit the
automation again, and it will automatically set the correct
"samePropertyOp" flag.
—
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFBLHOSEG7L5XOD367Q4UFTXHJV3HANCNFSM6AAAAAAYIMZJU4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
from core.
ichibana
commented on August 25, 2024
Hey Igor -
Just uploaded a new activity that still failed the OR flow, FYI.
Thanks,
KKM
On Sun, May 21, 2023 at 13:35 Igor Ramadas ***@***.***> wrote:
Closed #28 <#28> as completed.
—
Reply to this email directly, view it on GitHub
<#28 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFBLHOQYK4VDWCHSIV6H35LXHJ4CRANCNFSM6AAAAAAYIMZJU4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
. . . . . . . . . . . . . . .
*Kiran K Malladi*
*he / him
<https://assets2.hrc.org/files/assets/resources/TalkingAboutPronouns_onesheet_FINAL.pdf>*
May 2023
from core.
igoramadas
commented on August 25, 2024
Hi Kiran,
I see you update an automation recently, but it was the other one (not the Workout / Pilates), so that one still had the samePropertyOp set to AND. I've manually removed the flag from that automation for you now.
If you have any other issues, please let me know :-)
from core.
ichibana
commented on August 25, 2024
Hi! Sorry, I didn't follow the response.
I'm also noticing that my "trainer" automation is triggering even for
Strava activities that don't meet this criteria. For example, last night I
uploaded a "workout", but it still triggered the trainer automation (and at
the time, didn't trigger the "core" automation).
KKM
…On Mon, May 22, 2023 at 12:09 AM Igor Ramadas ***@***.***> wrote:
Hi Kiran,
I see you update an automation recently, but it was the other one (not the
Workout / Pilates), so that one still had the samePropertyOp set to AND.
I've manually removed the flag from that automation for you now.
If you have any other issues, please let me know :-)
—
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFBLHOSJUFUYXBQBHCENRA3XHMGK3ANCNFSM6AAAAAAYIMZJU4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
from core.
igoramadas
commented on August 25, 2024
@ichibana I've followed you on Strava so I can see the activity details without having to impersonate your account via the API. Can you please let me know the workout activity ID that misfired the trainer automation?
from core.
ichibana
commented on August 25, 2024
ID 9117086090.
Thanks,
KKM
…On Mon, May 22, 2023 at 10:45 AM Igor Ramadas ***@***.***> wrote:
@ichibana <https://github.com/ichibana> I've followed you on Strava so I
can see the activity details without having to impersonate your account via
the API. Can you please let me know the workout activity ID that misfired
the trainer automation?
—
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFBLHOSKK4U7HZWQDXXDRELXHOQ3HANCNFSM6AAAAAAYIMZJU4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
from core.
igoramadas
commented on August 25, 2024
That activity is returning "trainer = true".
Can you please open https://www.strava.com/activities/9117086090/edit and check if the "Indoor" tag is marked?
from core.
ichibana
commented on August 25, 2024
Ah yes, it *is* tagged as "indoor". But not "indoor cycling". Should I use
"indoor cycling" as my trigger for the trainer?
Thanks,
KKM
…On Mon, May 22, 2023 at 2:40 PM Igor Ramadas ***@***.***> wrote:
That activity is returning "trainer = true".
Can you please open https://www.strava.com/activities/9117086090/edit and
check if the "Indoor" tag is marked?
—
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFBLHOST6J76GHETAFKIZK3XHPMNBANCNFSM6AAAAAAYIMZJU4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
from core.
igoramadas
commented on August 25, 2024
Strava doesn't make any distinctions, if it's indoor then it will have trainer = true.
On your case, you can add a second condition checking the sport type (Ride, VIrtual Ride etc). And of course, use AND as the logical operator.
from core.
ichibana
commented on August 25, 2024
Thank you! Will do :)
KKM
…On Tue, May 23, 2023 at 12:43 AM Igor Ramadas ***@***.***> wrote:
Strava doesn't make any distinctions, if it's indoor then it will have
trainer = true.
On your case, you can add a second condition checking the sport type
(Ride, VIrtual Ride etc). And of course, use AND as the logical operator.
—
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFBLHOWHVM4Q7VAXM4MG3NTXHRTAPANCNFSM6AAAAAAYIMZJU4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
from core.
Related Issues (20)
- Wind speed values seem very off (unnecessary conversion?) HOT 7
- Wrong Cadence on Running Activities HOT 8
- Weather.Start & Weather.End Identical? HOT 3
- Dutch language HOT 6
- Improvement OpenAI generated name: translation support HOT 4
- Weather tags translation improvements HOT 5
- Spotify integration not working HOT 7
- [Feature request] : mixing AND and OR HOT 3
- Bug: Automation keeps getting disabled HOT 8
- Feature request: Mark ride as NOT commute HOT 5
- Lithuanian language HOT 6
- Condition on app name HOT 3
- perceivedExertion not being expanded in template HOT 2
- I have to set End time -1 hr for the automation to trigger correctly HOT 7
- ${maxPace} for indoor activities HOT 7
- Does AI consider temperature being specified in Fahrenheit? HOT 7
- Account settings not saved HOT 2
- action to trigger "adjust elevation" for activities HOT 4
- AI activity name cutoff HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from core.