groupsRequired Middleware should support json response about express-stormpath HOT 4 OPEN

Am working on plans for this =) We'll get something in place soon. I've been trying to figure out a good way to handle this stuff.

from express-stormpath.

I'm a complete novice so this is probably way off base...

Could you just return an error rather than rendering a view at this level and then intercept this elsewhere and return the error in the right format for the client. A bit like the example [here]...(http://runnable.com/UTlPPV-f2W1TAAEf/custom-error-pages-in-express-for-node-js) but in this case obviously for errors other than the 404?

Would save repeating if (req.accepts(['html', 'json']) === 'html') etc... for all calls.

from express-stormpath.

Oh right -- I think the main issue is this though: coming up with a way to list all possible errors / exceptions, and let a user define values for them to override the defaults.

Right now the errors are (for the most part) returned properly based on the type of middleware (eg: stormpath.groupsRequired is meant for web users, not API stuff, which is why it's returning HTML). HOWEVER, I'd love to find a clean and sane way to let users overwrite the content of every single message in a single location.

I've been thinking about this for a while, and I have a few ideas:

1. Provide a huge JSON object that holds every possible error, something like:

{
  "loginAttemptBadPasswordProvided": {
    "html": "Invalid username or password.",
    "json": {
      "code": 400,
      "message": "Invalid username or password."
    }
  }
}

1. Force users to listen for errors and handle them on their own, eg:

app.get('stormpathApplication.').on('loginAttemptBadPasswordProvided', function(req, res) {
  res.json({ code: 400, message: 'Invalid username or password." });
});

Something like those is the best I've come up with so far :(

from express-stormpath.

Not easy I know, much prefer the first solution personally.

In the meantime an API equivalent of stormpath.groupsRequired similar to the authenticationRequired middleware that was added would be nice. I’d have thought this was pretty important functionality for a lot of use cases.

Cheers

from express-stormpath.