Comments (7)
Hey @sFrenkie, thanks for reporting this!
I think this is related to the stimulus_reflex_testing
gem.
We changed the way cable_ready is accessed within the Reflex class in d493e1b
I'll try to put up a pull request for the testing gem to get this resolved!
from stimulus_reflex.
It seems that is not related to stimulus_reflex_testing
but in stimulus_reflex-3.5.0.rc2/lib/stimulus_reflex/cable_readiness.rb
the block prepended expect the arguments (usualy method prepended is from core Ruby e.g. for Ruby 3.0 https://ruby-doc.org/core-3.0.0/Module.html#method-i-prepended)
It expects use prepended from active concern so it seems that some requires does not worked for me
from stimulus_reflex.
Confirmed it's cause old rails 6.0.6 where arguments is expected https://api.rubyonrails.org/v6.0.6.1/classes/ActiveSupport/Testing/SetupAndTeardown.html#method-c-prepended
from rails 6.1 is optional
from stimulus_reflex.
@sFrenkie Would it help if make the argument optional?
diff --git a/lib/stimulus_reflex/cable_readiness.rb b/lib/stimulus_reflex/cable_readiness.rb
index 9bb2345..14b85a9 100644
--- a/lib/stimulus_reflex/cable_readiness.rb
+++ b/lib/stimulus_reflex/cable_readiness.rb
@@ -6,7 +6,7 @@ module StimulusReflex
module CableReadiness
extend ActiveSupport::Concern
- prepended do
+ prepended(mod = nil) do
attr_reader :cable_ready
end
from stimulus_reflex.
I guess the other option would be to stop supporting Rails 6.0 with StimulusReflex 3.5
from stimulus_reflex.
Sorry for delay. Yeat it's better to stop supporting rails 6 ;)
I've ugpraded and it works well.
from stimulus_reflex.
Awesome, thank you for the feedback @sFrenkie!
from stimulus_reflex.
Related Issues (20)
- Controller over reflex attribute is ignore and reflex is always called with default StimulusReflexController HOT 7
- Broken Next Page Link on Welcome Page of Docs HOT 2
- HEAD and most of the latest releases are broken, references an undefined exception
- StimulusReflex is not compatible with the standalone ActionCable server HOT 9
- Wrong dataset getting from Docs example HOT 2
- NameError: undefined local variable or method `package_json' HOT 3
- Reflex not triggered when a Stimulus controller is also attached to a field HOT 4
- Form parse errors are not captured and reported back to front-end
- Drop Rails 5 and 6.0 support
- `solid_cache` seems to work as well as Rails cache store HOT 1
- Add full-stack tests
- Stimulus_reflex and esbuild error HOT 1
- OpenStruct no longer supported by json HOT 1
- Refactor away instances of OpenStruct
- NameError: uninitialized constant StimulusReflex::Installer::Thor when running rake tasks HOT 1
- Support `relative_url_root`
- Could not find generator 'stimulus_reflex:initializer'
- Unrecognized command "esbuild" (Rails::Command::UnrecognizedCommandError)
- Installer should work in CI (noninteractive) environment
- docs recommend hiredis gem along with incompatible redis version
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stimulus_reflex.