file name and line number for error logging about ampm HOT 4 CLOSED

ampm won't know anything about your source code, so yes, you'd need to send it things like line numbers and file names. If AMPMClient.cpp could be changed such that it had an error method which automatically collected that info and sent it on to ampm, that would be most welcome.

The JavaScript client does send the stack trace and line numbers on errors, maybe you could do similar for c++.
https://github.com/stimulant/ampm/blob/master/samples/web/libs/ampm.js#L134

from ampm.

The current AMPMClient.cpp sends through line and lineNum to the server, but these are ignored by the server?

I'm happy just prepending the location data to the message, but looking at AMPMClient.cpp made me think this wasn't expected.

from ampm.

I looked into this. The log object is making it through to _logMessage here, but only the .message attribute ends up in the log file.

https://github.com/stimulant/ampm/blob/master/model/logging.js#L215

AMPMClient.cpp probably shouldn't construct a message object like that, because you'd reasonably assume something is happening with the other attributes... but it's not. A great PR would be to change it to examine the level to see if it's error, and if so, construct a string with all the info you want in it, which is what the JavaScript client does.

from ampm.

Okay, that makes sense to me. The file and line number already have to come from the client app, so we might as well bake it into the message on the client side (which is what I ended up doing).

from ampm.