Giter Club home page Giter Club logo

Comments (3)

stevengharris avatar stevengharris commented on June 11, 2024 1

Yes, see #30 for some details. Thanks for this and the other report. I am hoping to work on the open issues this week.

from splitview.

stevengharris avatar stevengharris commented on June 11, 2024 1

This should be fixed with #33. Also, thanks to your suggestion, I added toggle(_ side: SplitSide? = nil) as a method on SideHolder. The default behavior of toggle() will remain the same, which is to operate on the .secondary side. I can see your point that this might couple logically to priority if you are specifying it, but I generally think of these things as orthogonal, and dreaded having to explain about how they were coupled only if you specified priority 🤪.

As a result, though, your example showing the problem now looks like this for me:

VStack {
    Split(primary: {
        Color.teal
    }, secondary: {
        Color.green
    })
    .constraints(minPFraction: minPFraction, priority: .left, dragToHideP: true)
    .fraction(fraction)
    .hide(hide)
    Button("Toggle Hide") {
        withAnimation {
            hide.toggle(.left)
        }
    }
}

and works properly. Note that per #30, the splitter is completely hidden (currently by design) when the minPFraction is specified. I'll be working on making that optional next.

from splitview.

bastiaanterhorst avatar bastiaanterhorst commented on June 11, 2024

To be clear: when I remove the minPFraction property, it works. So it looks like setting a minimum fraction is incompatible with hiding a split.

from splitview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.