Giter Club home page Giter Club logo

Comments (9)

notjustinshaw avatar notjustinshaw commented on May 22, 2024 2

I've been able to implement dark-mode in tailwind with the typography plugin with just prose dark:prose-invert.

from novel.

Dhravya avatar Dhravya commented on May 22, 2024 1

Yeah, I fixed all the issues you mentioned in the above commits already. 😁

Why cookies: it's hard to manage global state in server components, local storage could be done but this was a very straightforward approach, so I went with it

from novel.

steven-tey avatar steven-tey commented on May 22, 2024

Yeah I tried adding that before, unfortunately we're blocked by Tailwind Typography not supporting dark mode with prose-invert: tailwindlabs/tailwindcss-typography#228

cc: @adamwathan

from novel.

steven-tey avatar steven-tey commented on May 22, 2024

@notjustinshaw 👀 that's awesome! Feel free to make a PR to add dark mode to Novel! 😄

from novel.

Dhravya avatar Dhravya commented on May 22, 2024

I could get darkmode to work, I'm using cookies to store current mode

GIF demo

from novel.

sreehari2003 avatar sreehari2003 commented on May 22, 2024

I could get darkmode to work, I'm using cookies to store current mode

GIF demo GIF demo

this dark mode ui looks in consistent , that toggle button size is large , continue writing icon missing etc also y store in cookie ? i think it is better to store the theme state in local storage than cookies

from novel.

Dhravya avatar Dhravya commented on May 22, 2024

Yeah, I fixed all the issues you mentioned in the above commits already. 😁

Why cookies: it's hard to manage global state in server components, local storage could be done but this was a very straightforward approach, so I went with it

from novel.

Amsalak avatar Amsalak commented on May 22, 2024

Ne olduğunu anlamayan yine ben

from novel.

steven-tey avatar steven-tey commented on May 22, 2024

Dark mode is now live!! #80

from novel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.