Comments (7)
SteveGilham
commented on August 25, 2024
Thank you for the repro code. At the moment I'll make no guesses as to what is going on.
The section of code you quote is from the executable to drive an old version of the Mono C# (hence M CS) compiler library, which I use to create test data with .mdb symbols; it's for backward compatibility testing, and not part of the actual instrumentation process, so is likely a red herring.
from altcover.
SteveGilham
commented on August 25, 2024
Having slept on the issue, the first thing that occurs to me is to validate an assumption and ask what happens with
Directory.CreateDirectory(currentPath + "longdirectoryname/");
Assert.IsTrue(Directory.Exists(currentPath + "longdi~1/")); // is that the actual short name??
var actualPath = Path.GetFullPath(currentPath + "longdi~1/");and also P/Invoke GetShortPathName from kernel32.dll to find out what's really happening here.
from altcover.
SteveGilham
commented on August 25, 2024
Interesting. I run this test program as-is (altcover not used)
module TestProject1
open NUnit.Framework
open System
open System.IO
open System.Runtime.InteropServices
open System.Text
[<DllImport("kernel32.dll", CharSet = CharSet.Auto)>]
extern int GetShortPathName(
[<MarshalAs(UnmanagedType.LPTStr)>]
string path,
[<MarshalAs(UnmanagedType.LPTStr)>]
StringBuilder shortPath,
int shortPathLength
)
[<SetUp>]
let Setup () =
()
[<Test>]
let Test1 () =
let basePath = Directory.GetCurrentDirectory()
Assert.That(basePath, Does.Not.EndWith("\\"))
Assert.That(basePath, Does.Not.EndWith("/"))
let currentPath = basePath + "\\"
Assert.That(currentPath, Does.EndWith("\\"))
printfn "CurrentPath %A" currentPath
let longname = currentPath + "longdirectoryname/"
let longdir = Directory.CreateDirectory(longname)
printfn "longdir %A" longdir.FullName
let shortPathBuilder = new StringBuilder(65000)
GetShortPathName(longdir.FullName, shortPathBuilder, shortPathBuilder.Capacity) |> ignore
let shortPath = shortPathBuilder.ToString();
printfn "shortPath %A" shortPath
let actualPath = Path.GetFullPath(currentPath + "longdi~1/")
printfn "actualPath %A" actualPath
Assert.Multiple (fun () ->
Assert.That(Directory.Exists(actualPath), Is.True, "Directory not found")
Assert.IsTrue(String.Compare(currentPath + "longdirectoryname/", actualPath) = 0, "full name mismatch"))
Directory.Delete(currentPath + "longdirectoryname/")and get as test output in VisualStudio
Test1
Source: UnitTest1.fs line 24
Duration: 38 ms
Message:
Multiple failures or warnings in test:
1) Directory not found
Expected: True
But was: False
2) full name mismatch
Expected: True
But was: False
Stack Trace:
TestProject1.Test1() line 40
1) at [email protected]() in D:\Github\TestProject1\TestProject1\UnitTest1.fs:line 41
Assert.Multiple(TestDelegate testDelegate)
TestProject1.Test1() line 40
2) at [email protected]() in D:\Github\TestProject1\TestProject1\UnitTest1.fs:line 42
Assert.Multiple(TestDelegate testDelegate)
TestProject1.Test1() line 40
Standard Output:
CurrentPath "D:\Github\TestProject1\TestProject1\bin\Debug\net8.0\"
longdir "D:\Github\TestProject1\TestProject1\bin\Debug\net8.0\longdirectoryname\"
shortPath "D:\Github\TestProject1\TestProject1\bin\Debug\net8.0\longdirectoryname\"
actualPath "D:\Github\TestProject1\TestProject1\bin\Debug\net8.0\longdi~1\"
This may be a result of one or other of the settings to remove the windows 255-character path length restriction on my Windows 11 dev machine (similarly dir /X at a cmd prompt shows no 8.3-style names).
from altcover.
SteveGilham
commented on August 25, 2024
Digging out an old laptop that does show 8.3 names, and changing the penultimate line to
Assert.That(String.Compare(currentPath + "longdirectoryname\\", actualPath) = 0, "full name mismatch"))does make the test pass.
So, can we ascertain whether 8.3 names are working at all on your test machine?
from altcover.
SteveGilham
commented on August 25, 2024
Adding the console log from the run that succeeded, which I forgot to do this morning -
PS C:\Users\steve\source\repos\TestProject1\TestProject1> dotnet test /p:AltCover=true /p:AltCoverLocalSource=true
Determining projects to restore...
All projects are up-to-date for restore.
TestProject1 -> C:\Users\steve\source\repos\TestProject1\TestProject1\bin\Debug\net8.0\TestProject1.dll
Creating folder C:\Users\steve\source\repos\TestProject1\TestProject1\bin\Debug\net8.0\__Instrumented_TestProject1\
Instrumenting files from C:\Users\steve\source\repos\TestProject1\TestProject1\bin\Debug\net8.0\
Writing files to C:\Users\steve\source\repos\TestProject1\TestProject1\bin\Debug\net8.0\__Instrumented_TestProject1\
=> C:\Users\steve\source\repos\TestProject1\TestProject1\bin\Debug\net8.0\TestProject1.dll
Coverage Report: C:\Users\steve\source\repos\TestProject1\TestProject1\coverage.xml
C:\Users\steve\source\repos\TestProject1\TestProject1\bin\Debug\net8.0\__Instrumented_TestProject1\TestProject1.d
ll
<= TestProject1, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null
Settings Before:
Settings After: C:\Users\steve\AppData\Local\Temp\tmpquhfg5.altcover.runsettings
Test run for C:\Users\steve\source\repos\TestProject1\TestProject1\bin\Debug\net8.0\__Instrumented_TestProject1\TestProject1.dll (.NETCoreApp,Version=v8.0)
Microsoft (R) Test Execution Command Line Tool Version 17.9.0 (x64)
Copyright (c) Microsoft Corporation. All rights reserved.
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
CurrentPath "C:\Users\steve\source\repos\TestProject1\TestProject1\bin\Debug\net8.0\__Instrumented_TestProject1\"
longdir "C:\Users\steve\source\repos\TestProject1\TestProject1\bin\Debug\net8.0\__Instrumented_TestProject1\longdirectoryname\"
shortPath "C:\Users\steve\source\repos\TESTPR~1\TESTPR~1\bin\Debug\net8.0\__INST~1\LONGDI~1\"
actualPath "C:\Users\steve\source\repos\TestProject1\TestProject1\bin\Debug\net8.0\__Instrumented_TestProject1\longdirectoryname\"
Passed! - Failed: 0, Passed: 1, Skipped: 0, Total: 1, Duration: 417 ms - TestProject1.dll (net8.0)
... C:\Users\steve\source\repos\TestProject1\TestProject1\coverage.xml.0.acv (124b)
22 visits recorded in 00:00:00.0111442 (1,974 visits/sec)
A total of 22 visits recorded
Coverage statistics flushing took 0.05 seconds
Visited Classes 2 of 3 (66.67)
Visited Methods 3 of 4 (75)
Visited Points 21 of 22 (95.45)
Visited Branches 0 of 4 (0)
Maximum CRAP score 2
==== Alternative Results (includes all methods including those without corresponding source) ====
Alternative Visited Classes 2 of 3 (66.67)
Alternative Visited Methods 4 of 5 (80)
Alternative maximum CRAP score 2
from altcover.
nmoinvaz
commented on August 25, 2024
The section of code you quote is from the executable... for backward compatibility testing, and not part of the actual instrumentation process, so is likely a red herring.
Sorry about that then, I thought this might have been the culprit, because it stopped working after adding AltCover to the project.
So, can we ascertain whether 8.3 names are working at all on your test machine?
What I am seeing is that 8.3 names are working on NTFS, but not on ReFS (dev drive). But it appears that ReFS removes 8.3 filenames, so I suppose that is expected. I need to double check my CI to see there is no problem there where I originally spotted the problem.
from altcover.
nmoinvaz
commented on August 25, 2024
My issue on the CI ended up being something else. It was running all projects using dotnet test mysolution.sln and I had to implement this: https://dasmulli.blog/2018/01/20/make-dotnet-test-work-on-solution-files/
Thank you for your help on my issue report!!
from altcover.
Related Issues (20)
- `dotnet test /p:AltCover=true /p:AltCoverInPlace=true` results in System.IO.IOException: The process cannot access the file 'C:\src\testprj\bin\Debug\net8.0\AltCover.Recorder.g.dll' because it is being used by another process. HOT 5
- help with getting started HOT 2
- Could not find coverage.xml.zip when running Instrumented binaries HOT 5
- Adding AltCover to projects results in dotnet test running against all projects in solution HOT 6
- Running AltCover Runner in parallel mode HOT 2
- Question about cyclomatic complexity for pattern match HOT 2
- Changes so AltCover will run when FIPS compliance is required HOT 13
- .../Temp/tmp###.altcover.runsettings not found Intermittent tests ignored. HOT 2
- BranchPoints differ between .NET Framework and .NET 7 when using interpolated strings HOT 5
- Question Regarding assemblies being added to code coverage result HOT 2
- Command vstest.console.exe not started. Why? HOT 3
- altcover runner --OutputFile gives incorrect summary output HOT 8
- ERROR *** Instrumentation phase failed - Failed to resolve assembly: System.Data.Common HOT 8
- Generic methods share the same name and signature HOT 5
- Collection phase failed with an Error HOT 9
- Per-test level code coverage HOT 2
- Coverage collection requires instrumented code in same location until collection is not completed causing service downtime HOT 4
- Question : Codecov says braces are not covered HOT 2
- test run duration degredation when upgrading from 8.8.74 to 8.8.165? HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from altcover.