honor http proxy/proxy_auth about kitchen-oci HOT 8 CLOSED

so for now I'm monkey patching it for exactly this case (ignoring non proxy envs) with the following in my kitchen.yml:

<%
require 'oci/api_client'

module OCI
  class ApiClient
  def get_http_object(hostname, port)

       proxy=URI.parse(ENV['http_proxy'])

      Net::HTTP.new(
        hostname,
        port,
        proxy.host,
        proxy.port,
        proxy.user,
        proxy.password
      )
    end
  end
end

%>

from kitchen-oci.

@ehaselwanter I agree, that logic in the get_http_object method does look a bit suspect, but we'll just have to work around it.

I think for our purposes it's entirely sensible to pull the proxy settings from the environment as a fallback. Generally more specific settings should override less specific settings, so the .kitchen.yml proxy settings (if any exist) should override the environment.

I'll try to add something over the next few days, or do feel free to submit a PR if you end up coding something yourself.

from kitchen-oci.

yeah. I guess it should work like in kitchen-ec2 (https://github.com/test-kitchen/kitchen-ec2/blob/4adaa2a297cb614218025948915527ca153c109f/lib/kitchen/driver/ec2.rb#L403) / https://github.com/test-kitchen/kitchen-ec2#http_proxy . least surprise. for now I'll stick to the patch

from kitchen-oci.

@ehaselwanter If you get a chance, could you try out version 1.3.0 in branch feature/proxy_support and in PR #9. It seems to work in my tests, so I will merge it into master if it works for you too.

from kitchen-oci.

will do and report back tomorrow

from kitchen-oci.

can verify that it works with export http= as well as kitchen.yml config :-)

from kitchen-oci.

Great! , I will merge it. Thank you.

from kitchen-oci.

tested updated gem. works. thx :-)

from kitchen-oci.