Giter Club home page Giter Club logo

Comments (4)

StephenCleary avatar StephenCleary commented on August 13, 2024

The asynchronous methods only take a CT if the CT has a semantic meaning to the synchronization primitive (i.e., the state would change as a result of the method executing). In a MRE, the "Wait" operation does not change any state.

In other words, for a AMRE.WaitAsync(CT), the CT would only cancel the await, not have any affect on the AMRE.

You can cancel any await using ToCancellationTokenTaskSource, and adding CT support to WaitAsync would just wrap that anyway.

Contrast this with the Auto-Reset Event. For that type, the "Wait" operation does change the event state, so proper CT support is necessary.

That said, this has been a source of confusion for people, and I'm considering adding CT support even when the semantics are only to cancel the awaits, in a future .NET Core version.

from asyncex.

niemyjski avatar niemyjski commented on August 13, 2024

Thanks for this info, I took a look at ToCancellationTokenTaskSource but I didn't find any tests / examples of this. I'm guessing you were doing a continue with on the ToCancellationTokenTaskSource??

from asyncex.

StephenCleary avatar StephenCleary commented on August 13, 2024

You can use it like this:

async Task WaitAsync(Task operation, CancellationToken token)
{
  using (var ctSource = token.ToCancellationTokenTaskSource())
  {
    await await Task.WhenAny(operation, ctSource.Task);
  }
}

from asyncex.

niemyjski avatar niemyjski commented on August 13, 2024

Thanks! :)

from asyncex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.