Comments (4)
stephenberry
commented on July 23, 2024
Thanks for reporting this! I'm working on improvements to string reading/writing right now in #1168 and will also look into this.
from glaze.
stephenberry
commented on July 23, 2024
Oh, I see this isn't an issue with string reading, but whitespace handling for invalid inputs.
from glaze.
stephenberry
commented on July 23, 2024
The issue was not converting signed characters to uint8_t before looking up indexes in tables. This revealed a number of places for potential address issues that have now been fixed in #1168
from glaze.
stephenberry
commented on July 23, 2024
Note that in order for your test to be correct it should be: expect(glz::read_json(obj, buffer));. Remove the not because an error code is expected since this is invalid input for a JSON object.
But, thanks so much for revealing this issue!
from glaze.
Related Issues (20)
- add IWYU pragma to internal headers HOT 1
- [Question] Support for non-UTF-8 values? HOT 3
- Parsing glz::json_t using glz::read_json HOT 1
- Missed Breaking Change for Cpp 23 HOT 4
- prettify_json("\xf3") invokes out ouf bounds read in prettify.hpp HOT 3
- reading generic json on invalid input causes out of bounds read in read.hpp HOT 1
- reading generic json can cause a stack overflow HOT 2
- prettify_json("\"") invokes memcpy on nullptr in dump.hpp HOT 8
- glz::minify_json invoked on "f" causes out of bounds read in minify.hpp HOT 3
- CMAKE Version update HOT 2
- converting float -8536070.f to string gives "-08536070" HOT 10
- Optionally Write Keys at Runtime (while using Partials) HOT 2
- Roundtrip failure for double -0x1.e42427b42cb42p+949 HOT 2
- out of bounds write in prettify_json
- read_json on json_t invoked with invalid unicode causes out of bounds read in hex_to_u32 HOT 1
- [BUG?] Build fails on latest version (using g++) HOT 1
- deprectaed in c++17 out-of-line definition of constexpr static data member HOT 1
- clang - remainder by zero is undefined HOT 1
- size_t wraparound causes huge allocation when reading generic json
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from glaze.