Missing properties about docker-compose-types HOT 5 CLOSED

Hi @k9withabone, I'm happy for any contributions, these should be simple to add, feel free to do it in one pull request. There tests are also failing (I discovered I wasn't parsing all the example files in our suite) which might add some more to your list.

from docker-compose-types.

I've gotten my list completed. Ended up refactoring a few things since this will be a breaking change anyway. I was wondering what your opinion is on Option<Vec<T>> vs Vec<T> for optional fields. Most of the code uses the former, but there is some mixing of the two, for example in Service. Personally, I prefer Vec<T>, but there are arguments for both. I don't mind going through the code and standardizing it either way.

Anyway, on to the tests!

from docker-compose-types.

@k9withabone I think Vec<T> is a good solution, with the option to use serde to just not serialize empty vec (#[serde(default, skip_serializing_if = "Vec::is_empty")]). Some of the code in the project is very old, and would reflect a different level of understanding of the language and the crates that I used.

from docker-compose-types.

I've gotten most of the test files passing. I have a couple questions about the last few.
For tests/fixtures/extends/verbose-and-shorthand.yml it seems like it's invalid? From what I can tell the v2 spec doesn't support a shorthand syntax for extends:. Also, shouldn't they be under services:?
For tests/fixtures/net-container/v2-invalid.yml and tests/fixtures/v2-simple/links-invalid.yml they seem like they are valid even though they are marked as invalid?

from docker-compose-types.

@k9withabone I've worked with Docker Compose for many years but I don't know the exact answers above, I would refer to the spec just like you did. I copied those fixtures from the main docker project, its possible that some of them were faulty/invalid/skipped.

from docker-compose-types.