Giter Club home page Giter Club logo

Comments (3)

nikhilsaraf avatar nikhilsaraf commented on August 12, 2024

@PedityOfficial Thanks for filing an issue.

Kelp operates under the assumption that the horizon server you provide will always be available. From your logs, it seems that the timing of when you faced the error coincides directly with when public horizon was down yesterday, causing your bot to crash. The behavior of the bot is unpredictable when it cannot reach horizon for now -- a crash is not surprising in such a case. This is definitely an issue, one that will be addressed in due time.

It is rare that public horizon is down and it's unfortunate that this rare event occurred only a day after you started Kelp. I'm not expecting you to see this issue again if public horizon remains stable.

I'm closing this issue for now since it's something we'll be working to fix soon. Feel free to re-open if you see this issue again.

from kelp.

skirsch avatar skirsch commented on August 12, 2024

why not just catch the error and try again at the next timeout interval? Crashing seems unfriendly.

from kelp.

 avatar commented on August 12, 2024

@nikhilsaraf , This issue happened again and as you said I am asking you for reopening this issue :)
I agree with @skirsch solution and there can be more possible solution as well. Hoping to see this gets fixed.

Log is attached here

2018/10/30 15:26:40 error: cannot load offers to compute liabilities for asset (native): Horizon error: "Interna
l Server Error". Check horizon.Error.Problem for more information.
2018/10/30 15:26:40 liabilities after resetting
2018/10/30 15:26:50 Can't load offers: error decoding horizon.Problem: EOF
2018/10/30 15:26:50 error: cannot load offers to compute liabilities for asset (native): error decoding horizon.
Problem: EOF
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x75a9bb]
goroutine 1 [running]:
github.com/lightyeario/kelp/plugins.(*SDEX).logLiabilities(0xc42015c120, 0x8b18ad, 0x6, 0x0, 0x0, 0x0, 0x0)
        /Users/nikhilsaraf/dev/go/src/github.com/lightyeario/kelp/plugins/sdex.go:435 +0xfb
github.com/lightyeario/kelp/plugins.(*SDEX).LogAllLiabilities(0xc42015c120, 0x8b18ad, 0x6, 0x0, 0x0, 0x0, 0x0, 0
x8b83f4, 0x10, 0xc420244c28, ...)
        /Users/nikhilsaraf/dev/go/src/github.com/lightyeario/kelp/plugins/sdex.go:443 +0x65
github.com/lightyeario/kelp/trader.(*Trader).update(0xc420657c48)
        /Users/nikhilsaraf/dev/go/src/github.com/lightyeario/kelp/trader/trader.go:105 +0x1e9
github.com/lightyeario/kelp/trader.(*Trader).Start(0xc420657c48)
        /Users/nikhilsaraf/dev/go/src/github.com/lightyeario/kelp/trader/trader.go:67 +0x6f
github.com/lightyeario/kelp/cmd.init.4.func1(0xb447e0, 0xc420069740, 0x0, 0x6)
        /Users/nikhilsaraf/dev/go/src/github.com/lightyeario/kelp/cmd/trade.go:109 +0x9d2
github.com/lightyeario/kelp/vendor/github.com/spf13/cobra.(*Command).execute(0xb447e0, 0xc4200696e0, 0x6, 0x6, 0
xb447e0, 0xc4200696e0)
        /Users/nikhilsaraf/dev/go/src/github.com/lightyeario/kelp/vendor/github.com/spf13/cobra/command.go:702 +
0x2c6
github.com/lightyeario/kelp/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xb44e40, 0x403dfc, 0xc420072058, 
0x0)
        /Users/nikhilsaraf/dev/go/src/github.com/lightyeario/kelp/vendor/github.com/spf13/cobra/command.go:783 +
0x2e4
github.com/lightyeario/kelp/vendor/github.com/spf13/cobra.(*Command).Execute(0xb44e40, 0x0, 0x7b1582)
        /Users/nikhilsaraf/dev/go/src/github.com/lightyeario/kelp/vendor/github.com/spf13/cobra/command.go:736 +
0x2b
main.main()
        /Users/nikhilsaraf/dev/go/src/github.com/lightyeario/kelp/main.go:10 +0x2d

from kelp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.