PhoneNumberField with max_length of 128. about django-phonenumber-field HOT 3 CLOSED

The value is just so hight to definitely be large enough for all phone numbers. And didn't see a performance impact in just setting it at this size. I guess something like 32 would have been enough as well.
Annoyingly this is not easy to change in hindsight. If we just change the value here, people using this field in re-usable apps will produce different database migrations based on which version of django-phonenumber-field they happen to have had installed when they created their migration. So it is likely that people will get warnings about missing migrations in a re-usable app (which they don't have control over), if they upgrade django-phonenumber-field in their project.

IMHO there is no significant performance reason to go through that hassle for this change. But I'm no database expert, so I may be wrong :-)

from django-phonenumber-field.

You are right, it don't have penalty on performance because CharField use varchar in MySQL and PostgreSQL at least and so use only necessary bytes, I agree that isn't needed to change the field size, but a comment on code or docs about the size would be nice (maybe that issue will work as documentation too). Anyway I was more curious about why use that size :D.

Thx for reply and btw, good job u have done in this fields 👍 .

from django-phonenumber-field.

instead something like 20 (1 for +, 3 for country code, 3 for area code, 13 for phone digits).

You're missing extensions to phone numbers in there (;ext=123) and also that some people use formats other than E164 for the database.

from django-phonenumber-field.