Giter Club home page Giter Club logo

Comments (12)

LazyNCoder avatar LazyNCoder commented on May 29, 2024 2

That's correct, I disabled the "auto correct" because sometimes it changes way too much. Like, rounds 137 to 140.
I have to say, disabling this option is problematic. It crashes if the values are not mod 2 when you're using crop tool. Python doesn't accept it, and so on.

I still think it should be sensitive about what mod we chose. Especially now that mod 2 is default.

Anyway, Mr. Dendraspis sir, thank you for answering my basic questions with such a great attitude. I really appreciate it.

from staxrip.

Dendraspis avatar Dendraspis commented on May 29, 2024 1

This could help to make everybody happy I guess:

from staxrip.

Dendraspis avatar Dendraspis commented on May 29, 2024 1

This option is just made to make the warning ignorable - the mechanism behind has not changed at all.

  1. This is probably because you've disabled Auto Correct Crop Values. Auto Crop values are adjusted when this option is selected only.
  2. That is something that could be improved, indeed. 🤔

I enabled "Auto correct crop values" and it changed 138 to 140. Which I think is over-cropping.

But it should match Mod 8 then. So what would be your solution? Keeping a bit of the black bar?

from staxrip.

Dendraspis avatar Dendraspis commented on May 29, 2024

Let's do it that way:

In older versions, if the output mod wasn't matched, it would throw an unskippable error

Yes, but dependent on other settings.
Just for information: it hasn't changed for years. 😁

but today I simply pressed 'next' without realizing it, which bypassed the modulus error.
Is there any way to force it to be unskippable? Otherwise it doesn't make any sense.

The reason is caused by disabling Auto Correct Crop Values.
If you disable it, the message becomes ignorable.

from staxrip.

Dendraspis avatar Dendraspis commented on May 29, 2024

I will have a look at what we can do about it...

from staxrip.

LazyNCoder avatar LazyNCoder commented on May 29, 2024

I can't thank you enough.

from staxrip.

LazyNCoder avatar LazyNCoder commented on May 29, 2024

Hi,

I got two problems with this new option.

1- It doesn't work on batch encodes I guess. I have "auto crop" on always. cropped 138px top and bottom (=804) and went on. Didn't care about output mod which was 8.

2- If you check the new option, ignore the warning by clicking on the accept button, uncheck it, it doesn't warn you anymore.

I enabled "Auto correct crop values" and it changed 138 to 140. Which I think is over-cropping.

from staxrip.

LazyNCoder avatar LazyNCoder commented on May 29, 2024

But it should match Mod 8 then. So what would be your solution? Keeping a bit of the black bar?

Well yeah, 2px black bar is better than 2px of the image removed IMO

from staxrip.

Dendraspis avatar Dendraspis commented on May 29, 2024

I could add an option to decrease the crop rather than increase it. 🤔

from staxrip.

LazyNCoder avatar LazyNCoder commented on May 29, 2024

Well, it's awesome to have an option to choose whatever the user wants. But I still think if it crops more than it should, it would make the result invalid. Either way, any fix for this is appreciated 🙂

from staxrip.

Dendraspis avatar Dendraspis commented on May 29, 2024

Well yeah, 2px black bar is better than 2px of the image removed IMO

In your case 6px black bar vs 2px into the image.

But I still think if it crops more than it should, it would make the result invalid

It somehow feels like we're talking about different things. 🤔

You run Auto Crop and the outcome is odd or doesn't match the Output Mod, then Auto Correct Crop Values kicks in to match the Output Mod you have set. This means that the crop has to be extended.

I guess this is one reason why the very most users prefer using Mod 2 as this makes you loose max. 1px while not keeping any black bars.

from staxrip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.