Giter Club home page Giter Club logo

Comments (9)

tersec avatar tersec commented on July 18, 2024 1

There's more value in keeping REST calls to be as close to only-beacon-API as possible. The more Nimbus-specific calls there are, the less interoperability, which partly defeats the point.

Metrics weren't ever broadly interoperable to begin with, so better to put client-specific things in metrics where feasible.

from nimbus-eth2.

tersec avatar tersec commented on July 18, 2024

nextProposalSlot is in the same Slot end log as nextActionWait.

from nimbus-eth2.

jakubgs avatar jakubgs commented on July 18, 2024

Okay, but can we get a metric?

from nimbus-eth2.

etan-status avatar etan-status commented on July 18, 2024

Would this one work for you?

Proposals are not so frequent, so it would be set to Inf if time to next one is unknown.

And, also added a boolean one for sync committee – they last ~27hrs though with a signature every 12 seconds, but during that time profit is massively increased so it may still be worthwhile to delay maintenance to the next day if it's not critical?
If you don't need sync committee I can also remove it again from the PR.

from nimbus-eth2.

jakubgs avatar jakubgs commented on July 18, 2024

Sync committee metric is also cool, thanks for this.

from nimbus-eth2.

cheatfate avatar cheatfate commented on July 18, 2024

You really need a metric for this? We could provide a REST call.

from nimbus-eth2.

jakubgs avatar jakubgs commented on July 18, 2024

Also, metrics have more uses than REST API calls. You can actually graph how often and how busy your node is.

from nimbus-eth2.

tersec avatar tersec commented on July 18, 2024

#6028

from nimbus-eth2.

jakubgs avatar jakubgs commented on July 18, 2024

I checked Prometheus for values of the new metric and it appears to work:

image

Thanks.

from nimbus-eth2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.